Skip to content

Bearer tokens are app token - #12543

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/12498/bearer_tokens_are_apptokens
Nov 20, 2018
Merged

Bearer tokens are app token#12543
MorrisJobke merged 1 commit into
masterfrom
fix/12498/bearer_tokens_are_apptokens

Conversation

@rullzer

@rullzerrullzer commented Nov 20, 2018

Copy link
Copy Markdown
Member

Fixes#12498

This means that we set that it is a proper app token once it is
validated. This will allow the 2FA middleware to just run the same
check.

@rullzer
Bearer tokens are app token
c2beb36
Fixes#12498
This means that we set that it is a proper app token once it is
validated. This will allow the 2FA middleware to just run the same
check.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Nov 20, 2018
@rullzerrullzer added this to the Nextcloud 15 milestone Nov 20, 2018
@rullzerrullzer mentioned this pull request Nov 20, 2018
Closed
@rullzer

rullzer commented Nov 20, 2018

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

@rullzer

rullzer commented Nov 20, 2018

Copy link
Copy Markdown
MemberAuthor

/backport to stable13

ChristophWurst
ChristophWurst approved these changes Nov 20, 2018
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

MorrisJobke
MorrisJobke approved these changes Nov 20, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 20, 2018
@MorrisJobke
MorrisJobke merged commit 53418f2 into masterNov 20, 2018
@MorrisJobke
MorrisJobke deleted the fix/12498/bearer_tokens_are_apptokens branch November 20, 2018 10:49
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Nov 20, 2018
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 20, 2018

Copy link
Copy Markdown

backport to stable14 in #12545

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Nov 20, 2018
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 20, 2018

Copy link
Copy Markdown

backport to stable13 in #12546

@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
Merged
7 tasks
@nextcloud-botnextcloud-bot mentioned this pull request Nov 26, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@ChristophWurst