Skip to content

Handle permission in update of share better - #12544

Merged
rullzer merged 1 commit into
masterfrom
fix/better_update_share_handling
Nov 20, 2018
Merged

Handle permission in update of share better#12544
rullzer merged 1 commit into
masterfrom
fix/better_update_share_handling

Conversation

@rullzer

@rullzerrullzer commented Nov 20, 2018

Copy link
Copy Markdown
Member

Hardening to prevent potential issues.

@rullzer
Handle permission in update of share better
a343a60
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added this to the Nextcloud 15 milestone Nov 20, 2018
@rullzer

rullzer commented Nov 20, 2018

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

@rullzer

rullzer commented Nov 20, 2018

Copy link
Copy Markdown
MemberAuthor

/backport to stable13

@rullzer

rullzer commented Nov 20, 2018

Copy link
Copy Markdown
MemberAuthor

/backport to stable12

MorrisJobke
MorrisJobke approved these changes Nov 20, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

ChristophWurst
ChristophWurst approved these changes Nov 20, 2018
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 20, 2018
@rullzer
rullzer merged commit 1bf742c into masterNov 20, 2018
@rullzer
rullzer deleted the fix/better_update_share_handling branch November 20, 2018 15:19
@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 20, 2018

Copy link
Copy Markdown

The backport to stable14 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 20, 2018

Copy link
Copy Markdown

The backport to stable13 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 20, 2018

Copy link
Copy Markdown

The backport to stable12 failed. Please do this backport manually.

This was referenced Nov 20, 2018
Merged
Merged
Merged
@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
Merged
7 tasks
@nickvergessennickvergessen mentioned this pull request Dec 5, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@schiessleschiessleAwaiting requested review from schiessle
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: sharing

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@ChristophWurst