Do not show tab headers marked as hidden

[danxuliu]

This pull request fixes a regression introduced in #12180

Tab headers that should not be shown are marked with the hidden CSS class. The CSS rules set display: none for .hidden elements, but as the rules for .tabHeaders .tabHeader are more specific than rules for .hiddenthe display property is overriden and ends being flex. Therefore, it is necessary to explicitly set a rule for .tabHeaders .tabHeader.hidden elements.

Before:

After:

@nextcloud/designers

[skjnldsv]

Seems fair to me!
Question: how do you end up with a hidden tab? Why would the tab be disabled? like version for a folder is not possible for example? (simple example, I have actually no idea 🤔 ) 😄

[danxuliu]

Question: how do you end up with a hidden tab? Why would the tab be disabled?

When the Files app is initialized all the sidebar plugins are registered and then, every time a file is selected, the plugins are shown or hidden depending on the current file.

like version for a folder is not possible for example? (simple example, I have actually no idea thinking )

No, versions are not supported in folders (or so it seems :-P ).

[skjnldsv]

That's what I thought.
What a terrible behavior :(

[danxuliu]

What a terrible behavior :(

I am curious :-) What would you suggest instead?

[jancborchardt]

Let’s open a separate issue about this discussion? :) This fixes a regression bug, and the discussion is opening a whole new topic of implementation.

[skjnldsv]

What a terrible behavior :(

I am curious :-) What would you suggest instead?

Let's go over #10289

[danxuliu]

Let’s open a separate issue about this discussion? :) This fixes a bug, and the discussion is opening a whole new topic of implementation.

Oh, it was just simple curiosity, I did not intend to discuss anything :-) But yes, I should have asked @skjnldsv by other channels, sorry :-)