Do not do redirect handling when loggin out

[rullzer]

Fixes#12568
Since the clearing of the execution context causes another reload. We
should not do the redirect_uri handling as this results in redirecting
back to the logout page on login.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

[nickvergessen]

I dislike this patch a bit, because if you are on a page which is publicly accessible, it loads that page, instead of redirecting to the login form.

In my head the following should have worked:

publicfunction showLoginForm(string$user = null, string$redirect_url = null): Http\Response {
if ($this->session->exists('clearingExecutionContexts')) {
$this->session->remove('clearingExecutionContexts');
$response = newRedirectResponse($this->urlGenerator->linkToRouteAbsolute('core.login.showLoginForm'));
$response->addHeader('Clear-Site-Data', '"cache", "storage", "executionContexts"');
return$response;
}

But while your request is on /login firefox reloads the last loaded page, which is still the previous page, so it also would reload the public call.

[rullzer]

Do you have a logout button on a public page?

[nickvergessen]

Well on Talk the same URL is used for a room independent of your login state.

[MorrisJobke]

@rullzer@nickvergessen What is the status here? Continue it or close it?

[rullzer]

Let me have another look. I might have a more elegant way

[rullzer]

@nickvergessen can you verify that this seems fixed with the latest firefox?

[rakekniven]

No, it is still the same with ff 65.

[nickvergessen]

Same here, still broken with FF 65.0

[rullzer]

Ok this is now a bit more elegant I think.

@nickvergessen please check it out

[nickvergessen]

That works perfectly.

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

Backport?

[rullzer]

Fine by me. It is mainly an added middleware. So should not cause issues.

[MorrisJobke]

/backport to stable15

[backportbot-nextcloud]

The backport to stable15 failed. Please do this backport manually.