Skip to content

Do not clear new user form on failure - #12587

Merged
MorrisJobke merged 1 commit into
masterfrom
new-user-clear-fix
Nov 22, 2018
Merged

Do not clear new user form on failure#12587
MorrisJobke merged 1 commit into
masterfrom
new-user-clear-fix

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

@nextcloud/designers

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
7 tasks
@MorrisJobke

Copy link
Copy Markdown
Member

@skjnldsv Could you recompile the vue app?

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

@skjnldsv rebase

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 22, 2018
@MorrisJobke

Copy link
Copy Markdown
Member

Acceptance tests fail:

 Scenario: create folder in a public editable shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:207
Given I act as John # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Editable shared folder" # FileListContext::iCreateANewFolderNamed()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I share the link for "Editable shared folder" # FilesAppContext::iShareTheLinkFor()
And I set the shared link as editable # FilesAppContext::iSetTheSharedLinkAsEditable()
And I write down the shared link # FilesAppContext::iWriteDownTheSharedLink()
Element is no longer attached to the DOM
For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
System info: host: '0a91777a3a8d', ip: '172.17.0.4', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-38-generic', java.version: '1.8.0_91'
Driver info: driver.version: unknown (WebDriver\Exception\StaleElementReference)
When I act as Jane # ActorContext::iActAs()
And I visit the shared link I wrote down # FilesSharingAppContext::iVisitTheSharedLinkIWroteDown()
And I see that the current page is the shared link I wrote down # FilesSharingAppContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
And I create a new folder named "Subfolder" # FileListContext::iCreateANewFolderNamed()
Then I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

@MorrisJobke

Copy link
Copy Markdown
Member

Acceptance tests fail:

Ah no - this is unrelated to the changes in here. Either a regression on master or a false positive. 🙈

@MorrisJobke
MorrisJobke merged commit e0967ff into masterNov 22, 2018
@MorrisJobke
MorrisJobke deleted the new-user-clear-fix branch November 22, 2018 13:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugdesignDesign, UI, UX, etc.feature: users and groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@MorrisJobke@ChristophWurst