Skip to content

Fix count on string - #12650

Merged
MorrisJobke merged 2 commits into
masterfrom
bugfix/12614/count-on-string
Nov 27, 2018
Merged

Fix count on string#12650
MorrisJobke merged 2 commits into
masterfrom
bugfix/12614/count-on-string

Conversation

@kesselb

Copy link
Copy Markdown
Contributor

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
rullzer
rullzer previously requested changes Nov 25, 2018
Comment threadapps/user_ldap/lib/Access.php Outdated
* @param string|string[]|null $attr
* @return bool
*/
private function manyAttributes($attr) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type can be set

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

🙈 🙉

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thx!

@blizzz

Copy link
Copy Markdown
Member

@rullzer mind a re-review?

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke
MorrisJobke merged commit 95857a8 into masterNov 27, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/12614/count-on-string branch November 27, 2018 13:14
@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable15

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable14

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable14 in #12684

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable14 in #12683

@kesselb

Copy link
Copy Markdown
ContributorAuthor

@rullzer 😕

@MorrisJobke

Copy link
Copy Markdown
Member

@rullzer 😕

Should be fixed by nextcloud/backportbot#12

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kesselb@blizzz@MorrisJobke@rullzer