Uh oh!
There was an error while loading. Please reload this page.
Don't require Same Site Cookies on accessibility app assets - #12669
Merged
Conversation
rullzer
commented
Nov 27, 2018
Member
How is accessibility triggered on public pages? As this is a user setting I think. |
tcitworld
commented
Nov 27, 2018
MemberAuthor
CSS is embed only when user is logged in, but JS is always here : https://github.com/nextcloud/server/blob/master/apps/accessibility/lib/AppInfo/Application.php |
rullzer
commented
Nov 27, 2018
Member
/backport to stable15 |
rullzer
approved these changes
Nov 27, 2018
MorrisJobke
approved these changes
Nov 29, 2018
backport to stable15 in #12731 |
MorrisJobke
commented
Nov 29, 2018
Member
It's easy - just add the "Signed-off-by: YOUR NAME your@email.com" to the commit message and it should be fine ;) |
tcitworld
commented
Nov 29, 2018
MemberAuthor
@MorrisJobke Yeah, I might as well have a WebExtension doing that for me. :D (and I'm not the only one todogroup/gh-issues#50 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #11878
(EDIT : Github web Editor is handy for tiny editions, but DCO doesn't like it of course.)