Uh oh!
There was an error while loading. Please reload this page.
Add theming information to capabilities for the client - #1272
Conversation
mention-bot
commented
Sep 5, 2016
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @schiessle and @juliushaertl to be potential reviewers |
| ); | ||
| $app = new \OCP\AppFramework\App('theming'); | ||
| $app->getContainer()->registerCapability(\OCA\Theming\Capabilities::class); |
There was a problem hiding this comment.
While backporting this needs to be made php 5.4 compatible
juliusknorr
commented
Sep 5, 2016
This is partly what #885 describes, right? Haven't looked into what capabilities exactly provide. Shouldn't we also add the background image and logo if they are set? |
AndyScherzinger
commented
Sep 5, 2016
@juliushaertl for theming information completeness yes, even though the server name and the graphics and colors are different issues client-feature-wise. |
nickvergessen
commented
Sep 5, 2016
Okay, well when we add the images (URLs? or full file?) then I guess a new route is better |
LukasReschke
commented
Sep 5, 2016
URL seems more flexible. |
juliusknorr
commented
Sep 5, 2016
ThemingDefaults::getLogo and ThemingDefaults::getBackground can be used there, they also return the URL for the default images if there are no custom ones set. |
karlitschek
commented
Sep 5, 2016
Easy enough that a backport makes sense 👍 |
nickvergessen
commented
Sep 6, 2016
Added the image URLs and tests |
MorrisJobke
commented
Sep 6, 2016
Tested and works 👍 |
rullzer
commented
Sep 6, 2016
LGTM |
Usefull for nextcloud/android#240
@AndyScherzinger@rullzer@MorrisJobke@schiessle
While this is an enhancement I would favor a backport, so the android app can use the name in 9 and 10 as well instead of having a useless "Nextcloud" in the title bar, to identfy the accounts. @karlitschek