Skip to content

Polishing of various modal dialogs - #12762

Merged
skjnldsv merged 1 commit into
masterfrom
auth-dialog-fix
Dec 3, 2018
Merged

Polishing of various modal dialogs#12762
skjnldsv merged 1 commit into
masterfrom
auth-dialog-fix

Conversation

@jancborchardt

@jancborchardtjancborchardt commented Nov 30, 2018

Copy link
Copy Markdown
Member

Dialogs to test with:

  • Authentication dialog e.g. when installing apps: Button to right, margins fixed.
    authentication dialog
  • File picker / Move or copy dialog: Fade on bottom right not fully overlapping scrollbar (cause of border-radius) fixed.
    copymove border radius
  • Avatar cropper in personal settings: Adjusted border-radii and drop-shadows to standard.
    avatar cropper
  • File conflict dialog in files: No change.

@jancborchardt
Fix dialogs, button position
2824622
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardtjancborchardt added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Nov 30, 2018
@jancborchardtjancborchardt added this to the Nextcloud 15 milestone Nov 30, 2018
@jancborchardtjancborchardt mentioned this pull request Nov 30, 2018
Closed
47 tasks
@weeman1337

weeman1337 commented Nov 30, 2018

Copy link
Copy Markdown
Member

Looks neat!

@jancborchardt

jancborchardt commented Dec 2, 2018

Copy link
Copy Markdown
MemberAuthor

What about the Drone checks here? Is this really blocking? cc @MorrisJobke@rullzer cause it’s polishing in several places.

@skjnldsv

skjnldsv commented Dec 3, 2018

Copy link
Copy Markdown
Member

Failure unrelated!

@skjnldsv

skjnldsv commented Dec 3, 2018

Copy link
Copy Markdown
Member

/backport to stable15

@skjnldsv
skjnldsv merged commit e7458a4 into masterDec 3, 2018
@skjnldsv
skjnldsv deleted the auth-dialog-fix branch December 3, 2018 06:30
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Dec 3, 2018
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Dec 3, 2018

Copy link
Copy Markdown

backport to stable15 in #12784

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weeman1337weeman1337weeman1337 approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@violoncelloCHvioloncelloCHAwaiting requested review from violoncelloCH

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

3 participants

@jancborchardt@weeman1337@skjnldsv