Skip to content

Log and continue on Dav reader failure (repair uid) - #12854

Merged
MorrisJobke merged 1 commit into
masterfrom
vcard-repair-uid-fix
Dec 5, 2018
Merged

Log and continue on Dav reader failure (repair uid)#12854
MorrisJobke merged 1 commit into
masterfrom
vcard-repair-uid-fix

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Dec 5, 2018•
edited
Loading

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv added bug 3. to review Waiting for reviews high labels Dec 5, 2018
@skjnldsvskjnldsv added this to the Nextcloud 16 milestone Dec 5, 2018
@skjnldsvskjnldsv self-assigned this Dec 5, 2018
@skjnldsv

skjnldsv commented Dec 5, 2018

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@skjnldsvskjnldsv changed the title Log and continue on Dav reader failureLog and continue on Dav reader failure (repair uid)Dec 5, 2018
ChristophWurst
ChristophWurst reviewed Dec 5, 2018
View reviewed changes
Comment threadlib/private/Repair/NC15/SetVcardDatabaseUID.php
Comment threadlib/private/Repair/NC15/SetVcardDatabaseUID.php Outdated
ChristophWurst
ChristophWurst requested changes Dec 5, 2018
View reviewed changes
Comment threadlib/private/Repair/NC15/SetVcardDatabaseUID.php Outdated
kesselb
kesselb reviewed Dec 5, 2018
View reviewed changes
Comment threadlib/private/Repair/NC15/SetVcardDatabaseUID.php Outdated
ChristophWurst
ChristophWurst requested changes Dec 5, 2018
View reviewed changes
Comment threadlib/private/Repair/NC15/SetVcardDatabaseUID.php
Comment threadlib/private/Repair/NC15/SetVcardDatabaseUID.php Outdated
ChristophWurst
ChristophWurst approved these changes Dec 5, 2018
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@skjnldsv

skjnldsv commented Dec 5, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

BTW, we fixed this, but any REPORT request to the addressbook containing this vcard will fail. So in the end This is not really great! This is a fix to a problem that should not have happened 😕

@georgehrke should we have an autofix for the vcards? What to do on that case? Any clue?
Should we warn the user?

@MorrisJobkeMorrisJobke mentioned this pull request Dec 5, 2018
Merged
12 tasks
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 5, 2018
@skjnldsv
Log and continue on Dav reader failure
2be63bc
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the vcard-repair-uid-fix branch from 619968a to 2be63bcCompareDecember 5, 2018 20:14
@MorrisJobke
MorrisJobke merged commit e808661 into masterDec 5, 2018
@MorrisJobke
MorrisJobke deleted the vcard-repair-uid-fix branch December 5, 2018 21:54
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Dec 5, 2018
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Dec 5, 2018

Copy link
Copy Markdown

backport to stable15 in #12867

@georgehrke

georgehrke commented Dec 6, 2018

Copy link
Copy Markdown
Member

@skjnldsv The corresponding function in the CalDAV backend always catches Exceptions: https://github.com/nextcloud/server/blob/v15.0.0RC2/apps/dav/lib/CalDAV/CalDavBackend.php#L1346L1360

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@kesselbkesselbkesselb approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@georgehrkegeorgehrkeAwaiting requested review from georgehrke

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbughigh

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv@georgehrke@ChristophWurst@kesselb@MorrisJobke