Uh oh!
There was an error while loading. Please reload this page.
Only execute query in propagateChange once - #12855
Merged
Merged
Conversation
The second execute statement should be inside the if block. Else it gets executed twice which makes no sense. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst, MorrisJobke, icewind1991, juliusknorr and nickvergessenDecember 5, 2018 19:43
ChristophWurst
commented
Dec 5, 2018
Member
backport= |
MorrisJobke
commented
Dec 5, 2018
Member
/backport to stable15 |
MorrisJobke
commented
Dec 5, 2018
Member
/backport to stable14 |
MorrisJobke
commented
Dec 5, 2018
Member
/backport to stable13 |
backport to stable15 in #12861 |
backport to stable14 in #12862 |
backport to stable13 in #12864 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second execute statement should be inside the if block. Else it gets
executed twice which makes no sense.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl