Skip to content

Change doc link for 15 - #12963

Merged
rullzer merged 1 commit into
stable15from
change-doc-link
Dec 10, 2018
Merged

Change doc link for 15#12963
rullzer merged 1 commit into
stable15from
change-doc-link

Conversation

@kesselb

@kesselbkesselb commented Dec 10, 2018

Copy link
Copy Markdown
Contributor

Ref #12959

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselbkesselb added the 3. to review Waiting for reviews label Dec 10, 2018
@kesselbkesselb added this to the Nextcloud 15 milestone Dec 10, 2018
$this->defaultAndroidClientUrl = $config->getSystemValue('customclient_android', 'https://play.google.com/store/apps/details?id=com.nextcloud.client');
$this->defaultDocBaseUrl = 'https://docs.nextcloud.com';
$this->defaultDocVersion = '14'; // used to generate doc links
$this->defaultDocVersion = '15'; // used to generate doc links

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv no on 15 we should use 15. Because once 16 is released we will forget to update this link.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rullzer but then stable will be 16 🤔

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#12896 when you merge this one defaultDocVersion will always point to the right number. You cant forget it anymore 😄 Unfortunately #12896 didn't made it into 15 😞

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv this PR is against stable15

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahaha, oups! 🙈

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hiding

@rullzer
rullzer merged commit 9b41fed into stable15Dec 10, 2018
@rullzer
rullzer deleted the change-doc-link branch December 10, 2018 12:09
@MorrisJobkeMorrisJobke mentioned this pull request Jan 4, 2019
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kesselb@rullzer@skjnldsv@MorrisJobke