Skip to content

add support for boolean default - #12969

Merged
nickvergessen merged 1 commit into
masterfrom
db-migration-boolean-default
Jan 9, 2019
Merged

add support for boolean default#12969
nickvergessen merged 1 commit into
masterfrom
db-migration-boolean-default

Conversation

@ArtificialOwl

@ArtificialOwlArtificialOwl commented Dec 10, 2018

Copy link
Copy Markdown
Member

if String, we add the quotes.
if Boolean, we just convert to string with no quote.
if else (numeric) we don't do anything

@ArtificialOwlArtificialOwl added the 3. to review Waiting for reviews label Dec 10, 2018
kesselb
kesselb reviewed Jan 4, 2019
View reviewed changes
Comment threadcore/Command/Db/Migrations/GenerateFromSchemaFileCommand.php Outdated
@kesselb

kesselb commented Jan 4, 2019

Copy link
Copy Markdown
Contributor

Before:

$table->addColumn('opened', 'boolean', [
'notnull' => true,
'default' => '1',
]);

After:

$table->addColumn('opened', 'boolean', [
'notnull' => true,
'default' => true,
]);

Tested with the news app 👍

@nickvergessennickvergessen added this to the Nextcloud 16 milestone Jan 8, 2019
@nickvergessen

nickvergessen commented Jan 8, 2019

Copy link
Copy Markdown
Member

/backport to stable15

@nickvergessen

nickvergessen commented Jan 8, 2019

Copy link
Copy Markdown
Member

/backport to stable14

nickvergessen
nickvergessen reviewed Jan 8, 2019
View reviewed changes
Comment threadcore/Command/Db/Migrations/GenerateFromSchemaFileCommand.php Outdated
@ArtificialOwl
ArtificialOwlforce-pushed the db-migration-boolean-default branch from c434620 to e947b3dCompareJanuary 9, 2019 09:52
@ArtificialOwl@nickvergessen
add support for boolean default
8002779
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
code cleaning
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
code cleaning
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@nickvergessen
nickvergessenforce-pushed the db-migration-boolean-default branch from e947b3d to 8002779CompareJanuary 9, 2019 10:21
@nickvergessennickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 9, 2019
@nickvergessen

nickvergessen commented Jan 9, 2019

Copy link
Copy Markdown
Member

Rebased, because drone exploded with the 7.0 tests

@nickvergessen
nickvergessen merged commit b8bb1d4 into masterJan 9, 2019
@nickvergessen
nickvergessen deleted the db-migration-boolean-default branch January 9, 2019 13:00
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jan 9, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Jan 9, 2019

Copy link
Copy Markdown

backport to stable15 in #13444

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jan 9, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Jan 9, 2019

Copy link
Copy Markdown

backport to stable14 in #13445

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@kesselbkesselbkesselb approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@ArtificialOwl@kesselb@nickvergessen