Skip to content

Fix required permissions for webdav move and copy - #1301

Merged
MorrisJobke merged 3 commits into
masterfrom
fix-required-permissions-for-webdav-move-and-copy
Sep 7, 2016
Merged

Fix required permissions for webdav move and copy#1301
MorrisJobke merged 3 commits into
masterfrom
fix-required-permissions-for-webdav-move-and-copy

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

3571207 broke the test_sharePermissions.py smashbox test

@rullzer@MorrisJobke@schiessle

Should backport to 10 and 9

@mention-bot

Copy link
Copy Markdown

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @icewind1991, @PVince81 and @DeepDiver1975 to be potential reviewers

@rullzer

Copy link
Copy Markdown
Member

Makes sense!
LGTM

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Found the breaking PR #255 (wasn't linked from the commit, but via backport it worked)

Vincent even commented exactly this: #255 (comment)

@MorrisJobke

Copy link
Copy Markdown
Member

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit c36ceb6 into masterSep 7, 2016
@MorrisJobke
MorrisJobke deleted the fix-required-permissions-for-webdav-move-and-copy branch September 7, 2016 17:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@mention-bot@rullzer@MorrisJobke