Skip to content

[15] upload new files in objectstore to a .part path first - #13036

Merged
rullzer merged 2 commits into
stable15from
objectstore-write-exists-15
Jan 14, 2019
Merged

[15] upload new files in objectstore to a .part path first#13036
rullzer merged 2 commits into
stable15from
objectstore-write-exists-15

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Backport of #13032

Signed-off-by: Robin Appelman <robin@icewind.nl>
This prevent the object store and cache from getting out of sync
when an objectstore silently fails or the php process get's killed
during the upload without giving us the chance to cleanup
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Dec 12, 2018
@icewind1991icewind1991 added this to the Nextcloud 15.0.1 milestone Dec 12, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Jan 4, 2019
3 tasks
*
* @param string $urn
* @return bool
* @since 15.0.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 15.0.3, but that should be fine as it should be used in 16+ only anyways.

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@rullzer
rullzer merged commit 412d6a4 into stable15Jan 14, 2019
@rullzer
rullzer deleted the objectstore-write-exists-15 branch January 14, 2019 10:29
@MorrisJobkeMorrisJobke mentioned this pull request Jan 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@rullzer@MorrisJobke