Skip to content

Fix update notification - #1307

Merged
nickvergessen merged 3 commits into
masterfrom
fix-update-notification
Sep 7, 2016
Merged

Fix update notification#1307
nickvergessen merged 3 commits into
masterfrom
fix-update-notification

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member
  • fixes the layout of the success message:

bildschirmfoto 2016-09-07 um 16 42 51

to

bildschirmfoto 2016-09-07 um 16 35 12

- updates the default updater URL to our server - this server is currently returning nothing, but this allows us in the future to provide update notifications - I tested the update server URL and it has no negative impact, that it simply provides an empty response

cc @LukasReschke @nextcloud/designers @nickvergessen@rullzer@karlitschek

@karlitschek I would like to backport at least the URL change to stable9 and stable10

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Sep 7, 2016
@MorrisJobkeMorrisJobke added this to the Nextcloud 11.0 milestone Sep 7, 2016
@MorrisJobke
MorrisJobkeforce-pushed the fix-update-notification branch from 09d3185 to 05580f0CompareSeptember 7, 2016 14:51
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

@rullzer Any idea why it fails?

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

@rullzer Any idea why it fails?

Nevermind.

@karlitschek

Copy link
Copy Markdown
Member

please backport all of it 👍

@nickvergessen

Copy link
Copy Markdown
Member

Should backport to 10 🙈

👍

@nickvergessen

Copy link
Copy Markdown
Member

stable9 has the updater url fixed, not sure who missed master back then

@MorrisJobke
MorrisJobkeforce-pushed the fix-update-notification branch from 732bd0c to 2d9574dCompareSeptember 7, 2016 15:27
@MariusBluem

Copy link
Copy Markdown
Member

👍 ... also for backporting 😉

@nickvergessen
nickvergessen merged commit b3d3a95 into masterSep 7, 2016
@nickvergessen
nickvergessen deleted the fix-update-notification branch September 7, 2016 16:40
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Backports are in #1312 and #1313

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbughigh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@karlitschek@nickvergessen@MariusBluem