Uh oh!
There was an error while loading. Please reload this page.
Only trust the X-FORWARDED-HOST header for trusted proxies - #13116
Merged
rullzer merged 1 commit intoDec 19, 2018
Conversation
nickvergessen
commented
Dec 17, 2018
Member
should also patch getServerProtocol Other than that 👍 good hardening |
nickvergessen
approved these changes
Dec 17, 2018
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
fix/only_trust_xforwardedhost_for_trusted_proxies
branch
from
December 17, 2018 14:54
7680e00 to
514426eComparekesselb
approved these changes
Dec 17, 2018
ChristophWurst
commented
Dec 18, 2018
Member
Anything missing? |
rullzer
commented
Dec 18, 2018
MemberAuthor
Litmus is failing. But unrelated I think |
rullzer
commented
Dec 18, 2018
MemberAuthor
/backport to stable15 |
rullzer
commented
Dec 19, 2018
MemberAuthor
Yep fails becaus of 740ea0d30e8e |
rullzer
deleted the
fix/only_trust_xforwardedhost_for_trusted_proxies
branch
December 19, 2018 08:47
backport to stable15 in #13150 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl