Uh oh!
There was an error while loading. Please reload this page.
Fix SAML Client login flow on Apple devices - #13118
Merged
Merged
Conversation
Because the redirect from the SAML/SSO endpoint is a POST the lax/strict cookies are not properly send. Note that it is not strictly requried on this endpoint as we do not need the remember me data. Only the real session info is enough. The endpoint is also already protected by a state token. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
mario
commented
Dec 17, 2018
Contributor
👍 |
rullzer
commented
Dec 17, 2018
MemberAuthor
/backport to stable15 |
rullzer
commented
Dec 17, 2018
MemberAuthor
/backport to stable14 |
rullzer
commented
Dec 17, 2018
MemberAuthor
/backport to stable13 |
mario
approved these changes
Dec 17, 2018
schiessle
approved these changes
Dec 17, 2018
backport to stable15 in #13123 |
backport to stable14 in #13124 |
backport to stable13 in #13125 |
marinofaggiana
commented
Dec 17, 2018
Member
👍 |
wiswedel
commented
Dec 17, 2018
Contributor
I have a client with (potentially) the same problem on the Windows client. Could this fix that too? |
mario
commented
Dec 17, 2018
Contributor
Yes @wiswedel :) |
wiswedel
commented
Dec 17, 2018
Contributor
@mario Great, so with 15.0.1 this should be fixed for them then? |
rullzer
commented
Dec 17, 2018
MemberAuthor
I'm not sure about windows as it might be a different issue. But maybe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the redirect from the SAML/SSO endpoint is a POST the lax/strict
cookies are not properly send.
Note that it is not strictly requried on this endpoint as we do not need
the remember me data. Only the real session info is enough. The endpoint
is also already protected by a state token.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl