Skip to content

SCSS cache buster is a combination of apps/theming/scc_vars - #13185

Merged
skjnldsv merged 1 commit into
masterfrom
fix/proper_version_theming_scss
Dec 21, 2018
Merged

SCSS cache buster is a combination of apps/theming/scc_vars#13185
skjnldsv merged 1 commit into
masterfrom
fix/proper_version_theming_scss

Conversation

@rullzer

Copy link
Copy Markdown
Member

Else on scss files we'd get ?v=?v=
This is of course not valid. Now it becomes ?v=-

Before: <server>/css/comments/ca9f-d135-comments.css?v=db81cddf52fdb3c8ca1e4c859e214124?v=ca9f0d77-0
After: <server>/css/comments/ca9f-d135-comments.css?v=db81cddf52fdb3c8ca1e4c859e214124-ca9f0d77-0

Else on scss files we'd get <file>?v=<hash>?v=<hash2>
This is of course not valid. Now it becomes <file>?v=<hash>-<hash2>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Dec 20, 2018
@rullzerrullzer added this to the Nextcloud 16 milestone Dec 20, 2018

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv

Copy link
Copy Markdown
Member

/backport to stable15

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #13209

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@skjnldsv@ChristophWurst