Uh oh!
There was an error while loading. Please reload this page.
CSP: Allow fonts to be provided in data - #13403
Merged
Merged
Conversation
rullzer
requested review from
ChristophWurst, MorrisJobke, nickvergessen and skjnldsvJanuary 7, 2019 12:32
rullzer
commented
Jan 7, 2019
MemberAuthor
/backport to stable15 |
skjnldsv
approved these changes
Jan 7, 2019
skjnldsv
commented
Jan 7, 2019
Member
|
rullzer
commented
Jan 7, 2019
MemberAuthor
Right. I'll fix the tests 🙈 |
rullzerforce-pushed
the
csp/allow_data_fonts
branch
from
January 7, 2019 12:58
159f788 to
983cd04CompareSigned-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
csp/allow_data_fonts
branch
from
January 7, 2019 14:07
983cd04 to
64244e1Comparebackport to stable15 in #13411 |
raimund-schluessler
commented
Jan 10, 2019
Member
Could this be backported to stable14 as well? Otherwise some apps will have to require NC15 just for the datepicker component. |
rullzer
commented
Jan 10, 2019
MemberAuthor
@raimund-schluessler I discussed this with @skjnldsv. THe trouble is of course that if an app is 14 compliant. It might still do 💥 if a user is not on the latest patch level... |
raimund-schluessler
commented
Jan 10, 2019
Member
True, but that is also the case for 15. |
skjnldsv referenced
this pull request
in nextcloud/contacts
Jan 10, 2019
skjnldsv
commented
Jan 10, 2019
Member
let's continue on nextcloud-libraries/nextcloud-vue#193 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for the dark mode of the vue components.