Skip to content

Don't log parameters on user creation in case of error/exception - #13473

Merged
rullzer merged 2 commits into
masterfrom
bugfix/noid/dont-log-parameters-on-user-creation-in-case-of-error
Jan 10, 2019
Merged

Don't log parameters on user creation in case of error/exception#13473
rullzer merged 2 commits into
masterfrom
bugfix/noid/dont-log-parameters-on-user-creation-in-case-of-error

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Method in question:

/**
* @PasswordConfirmationRequired
* @NoAdminRequired
*
* @param string $userid
* @param string $password
* @param string $displayName
* @param string $email
* @param array $groups
* @param array $subadmins
* @param string $quota
* @param string $language
* @return DataResponse
* @throws OCSException
*/
publicfunctionaddUser(string$userid,
string$password = '',
string$displayName = '',
string$email = '',
array$groups = [],
array$subadmin = [],
string$quota = '',
string$language = ''): DataResponse {

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added bug 3. to review Waiting for reviews labels Jan 10, 2019
@nickvergessennickvergessen added this to the Nextcloud 16 milestone Jan 10, 2019
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable13

@rullzer
rullzer merged commit b8b650a into masterJan 10, 2019
@rullzer
rullzer deleted the bugfix/noid/dont-log-parameters-on-user-creation-in-case-of-error branch January 10, 2019 11:36
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #13479

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable14 in #13480

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable13 failed. Please do this backport manually.

@MorrisJobke

Copy link
Copy Markdown
Member

The backport to stable13 failed. Please do this backport manually.

@nickvergessen Mind to do this as well?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@MorrisJobke@rullzer