Skip to content

Principals can be principal/user/<name> or principal/<name> from lega… - #13573

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/one-last-time
Jan 14, 2019
Merged

Principals can be principal/user/<name> or principal/<name> from lega…#13573
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/one-last-time

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jan 14, 2019

Copy link
Copy Markdown
Member

…cy installs

At least there is a conversion method:

server/apps/dav/lib/Connector/LegacyDAVACL.php

Lines 53 to 59 in d3d045d

privatefunctionconvertPrincipal($principal, $toV2) {
list(, $name) = \Sabre\Uri\split($principal);
if ($toV2) {
return"principals/users/$name";
}
return"principals/$name";
}

And a matching report by @cunningwasabi in #13499 (comment)

@nickvergessen
Principals can be principal/user/<name> or principal/<name> from lega…
4149d42
…cy installs
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added this to the Nextcloud 16 milestone Jan 14, 2019
rullzer
rullzer approved these changes Jan 14, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@nickvergessen

nickvergessen commented Jan 14, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@nickvergessen

nickvergessen commented Jan 14, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

@nickvergessen

nickvergessen commented Jan 14, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable13

skjnldsv
skjnldsv approved these changes Jan 14, 2019
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 14, 2019
@skjnldsv

skjnldsv commented Jan 14, 2019

Copy link
Copy Markdown
Member

Failure seems unrelated

@MorrisJobke
MorrisJobke merged commit c6cf871 into masterJan 14, 2019
@MorrisJobke
MorrisJobke deleted the bugfix/noid/one-last-time branch January 14, 2019 13:18
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jan 14, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Jan 14, 2019

Copy link
Copy Markdown

backport to stable15 in #13582

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jan 14, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Jan 14, 2019

Copy link
Copy Markdown

backport to stable14 in #13583

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jan 14, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Jan 14, 2019

Copy link
Copy Markdown

backport to stable13 in #13584

BernieO referenced this pull request in BernieO/calcardbackup Feb 13, 2019
@BernieO
take into account that principals can be principals/<username> from l…
1c8fe29
…egacy installs
BernieO referenced this pull request in BernieO/calcardbackup Feb 14, 2019
@BernieO
take into account that principals can be principals/<username> from l…
da7b815
…egacy installs
Backport of commit 1c8fe29)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@blizzzblizzzblizzz approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@georgehrkegeorgehrkeAwaiting requested review from georgehrke

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: dav

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@skjnldsv@rullzer@blizzz@MorrisJobke