Skip to content

Fix app navigation flickering on hover - #13574

Merged
MorrisJobke merged 1 commit into
nextcloud:masterfrom
alion300:master
Jan 16, 2019
Merged

Fix app navigation flickering on hover#13574
MorrisJobke merged 1 commit into
nextcloud:masterfrom
alion300:master

Conversation

@alion300

@alion300alion300 commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

i change the file by xaviterando done and fix
and i will do pull request to the solution becouse xavirando did pull request to him self

@alion300
the bug numbernextcloud#13263fixed by the xavierando user
6ad1a8f
i change the file by xaviterando done and fix
and i will do pull request to the solution becouse xavirando did pull request to him self
@ChristophWurst

ChristophWurst commented Jan 14, 2019

Copy link
Copy Markdown
Member

Ref #13263

@ChristophWurst

ChristophWurst commented Jan 14, 2019

Copy link
Copy Markdown
Member

@nickvergessen isn't that the bug that annoyed you? ;)

@ChristophWurstChristophWurst added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Jan 14, 2019
@ChristophWurstChristophWurst added this to the Nextcloud 16 milestone Jan 14, 2019
@juliusknorr

juliusknorr commented Jan 14, 2019

Copy link
Copy Markdown
Member

/backport to stable15

@juliusknorr

juliusknorr commented Jan 14, 2019

Copy link
Copy Markdown
Member

Thanks a lot for your contribution @alion300 🚀

There is only one thing missing - you need to add a sign-off message to the commits you made. Read more about this in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work

cc @xaviterando As he was the original author of the change.

@juliusknorr

juliusknorr commented Jan 14, 2019

Copy link
Copy Markdown
Member

CI failure unrelated

@juliusknorrjuliusknorr changed the title the bug number #13263 fixed by the xavierando userFix app navigation flickering on hoverJan 14, 2019
MorrisJobke
MorrisJobke approved these changes Jan 16, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit 355d69e into nextcloud:masterJan 16, 2019
@welcome

welcomeBot commented Jan 16, 2019

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jan 16, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Jan 16, 2019

Copy link
Copy Markdown

backport to stable15 in #13625

@jancborchardt

jancborchardt commented Jan 23, 2019

Copy link
Copy Markdown
Member

Great fix @alion300! :) Welcome to Nextcloud – any design fixes are always very welcome, if you like have a look at our Design page for more pointers. 🎉

@MorrisJobkeMorrisJobke mentioned this pull request Mar 8, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@jancborchardtjancborchardtAwaiting requested review from jancborchardt

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

5 participants

@alion300@ChristophWurst@juliusknorr@jancborchardt@MorrisJobke