Skip to content

Fix integer background job id type error - #13607

Merged
rullzer merged 1 commit into
masterfrom
fix/backgroundjob-int-id
Jan 15, 2019
Merged

Fix integer background job id type error#13607
rullzer merged 1 commit into
masterfrom
fix/backgroundjob-int-id

Conversation

@ChristophWurst

Copy link
Copy Markdown
Member

Fixes

{"reqId":"EHhZ5rL76Y4IGKW5rV51","level":3,"time":"2019-01-15T13:35:17+00:00","remoteAddr":"","user":"--","app":"cron","method":"","url":"--","message":{"Exception":"TypeError","Message":"Return value of OCP\\BackgroundJob\\Job::getId() must be of the type int, string returned","Code":0,"Trace":[{"file":"\/home\/christoph\/workspace\/nextcloud\/cron.php","line":118,"function":"getId","class":"OCP\\BackgroundJob\\Job","type":"->","args":[]}],"File":"\/home\/christoph\/workspace\/nextcloud\/lib\/public\/BackgroundJob\/Job.php","Line":117,"CustomMessage":"--"},"userAgent":"--","version":"16.0.0.0"}

That fails because of

finalpublicfunctiongetId(): int {
. I now just assumed they are always int, hence the type cast.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@rullzer

Copy link
Copy Markdown
Member

backport I assume?

@rullzer

Copy link
Copy Markdown
Member

/backport to stable15

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #13609

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@rullzer@nickvergessen@MorrisJobke