Skip to content

Fix empty content icons in header on darktheme - #13652

Merged
jancborchardt merged 1 commit into
masterfrom
bugfix/noid/darktheme-black-icon-on-empty-content
Jan 23, 2019
Merged

Fix empty content icons in header on darktheme#13652
jancborchardt merged 1 commit into
masterfrom
bugfix/noid/darktheme-black-icon-on-empty-content

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jan 17, 2019

Copy link
Copy Markdown
Member

Steps

  1. Open notifications dropdown when there are no notifications
  2. Open contact search and search for non-existing user

Before

icons are black/invisible

After

icons are white/visible

@nickvergessennickvergessen added this to the Nextcloud 16 milestone Jan 17, 2019
@nickvergessen

nickvergessen commented Jan 17, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@nickvergessen

nickvergessen commented Jan 17, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

@nickvergessennickvergessen mentioned this pull request Jan 21, 2019
Merged
16 tasks
jancborchardt added a commit that referenced this pull request Jan 21, 2019
@jancborchardt
Remove code fixed by@nickvergessenin#13652
0b201ec
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt

jancborchardt commented Jan 22, 2019

Copy link
Copy Markdown
Member

This works for the emptycontent icons, but for the contacts menu the other action icons are dark still:
contacts menu icons

And this needs rebasing onto master because #13648 was mergd. :)

@nickvergessen
Fix empty content icons on darktheme
71e394d
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/darktheme-black-icon-on-empty-content branch from 7fff43e to 71e394dCompareJanuary 23, 2019 11:56
@nickvergessen

nickvergessen commented Jan 23, 2019

Copy link
Copy Markdown
MemberAuthor

Rebased.

Also working fine here:

bildschirmfoto von 2019-01-23 12-55-57

But the default rebase solution broke to what you pointed out, so please check again

jancborchardt
jancborchardt approved these changes Jan 23, 2019
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what was wrong, looks great now!

@jancborchardt
jancborchardt merged commit f0ea696 into masterJan 23, 2019
@jancborchardt
jancborchardt deleted the bugfix/noid/darktheme-black-icon-on-empty-content branch January 23, 2019 22:44
@backportbot-nextcloud

backportbot-nextcloudBot commented Jan 23, 2019

Copy link
Copy Markdown

The backport to stable15 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Jan 23, 2019

Copy link
Copy Markdown

The backport to stable14 failed. Please do this backport manually.

@MorrisJobke

MorrisJobke commented Jan 30, 2019

Copy link
Copy Markdown
Member

@jancborchardt@skjnldsv@nickvergessen Mind to do the back ports?

@nickvergessen

nickvergessen commented Jan 30, 2019

Copy link
Copy Markdown
MemberAuthor

#13648 is missing, should be backported too?

@MorrisJobke

MorrisJobke commented Feb 12, 2019

Copy link
Copy Markdown
Member

#13648 is missing, should be backported too?

As this one is also not back ported I would leave it in master only.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardtjancborchardtjancborchardt approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: accessibility

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@jancborchardt@MorrisJobke@skjnldsv