Call proper function when fetching link shares in the breadcrumb view by juliusknorr · Pull Request #13734 · nextcloud/server

juliusknorr · 2019-01-22T12:15:56Z

Fixes call to undefined method.

TypeError
shareModel.hasLinkShare is not a function

Steps to reproduce:

Create a folder
Go into the folder
Click on the share icon in the breadcrumbs

Fixes#13056

juliusknorr · 2019-01-22T12:17:28Z

Sentry issue: NEXTCLOUD-H5

juliusknorr · 2019-01-22T12:18:29Z

/backport to stable15

skjnldsv

🙈

rullzer

🙈

skjnldsv · 2019-01-22T13:33:37Z

ERROR: 'Unhandled promise rejection', TypeError: null is not an object (evaluating 'xml.getElementsByTagNameNS')
_getSabreException@http://localhost:9876/base/core/js/files/client.js?45fcb98ff347716e68e4804dd65d22a9aee6777e:9:16109
http://localhost:9876/base/core/js/files/client.js?45fcb98ff347716e68e4804dd65d22a9aee6777e:9:24521
o@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:53950
http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:54095
u@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:51:98901
ERROR: 'Unhandled promise rejection', TypeError: null is not an object (evaluating 'xml.getElementsByTagNameNS')
_getSabreException@http://localhost:9876/base/core/js/files/client.js?45fcb98ff347716e68e4804dd65d22a9aee6777e:9:16109
http://localhost:9876/base/core/js/files/client.js?45fcb98ff347716e68e4804dd65d22a9aee6777e:9:24521
o@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:53950
http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:54095
u@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:51:98901
..................................................................
ERROR: 'Unhandled promise rejection', TypeError: null is not an object (evaluating 'xml.getElementsByTagNameNS')
_getSabreException@http://localhost:9876/base/core/js/files/client.js?45fcb98ff347716e68e4804dd65d22a9aee6777e:9:16109
http://localhost:9876/base/core/js/files/client.js?45fcb98ff347716e68e4804dd65d22a9aee6777e:9:19225
o@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:53950
http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:54095
u@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:51:98901
.............
ERROR: 'Unhandled promise rejection', TypeError: undefined is not an object (evaluating 'fileList.isEmpty')
http://localhost:9876/base/apps/files_trashbin/tests/js/filelistSpec.js?5fd90656cff4f49039c67b7230239608a2d9fa60:351:21
http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:39:47789
u@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:39:45231
fireWith@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:39:46034
http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:39:47909
u@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:39:45231
fireWith@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:39:46034
http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:39:48208
http://localhost:9876/base/core/js/files/client.js?45fcb98ff347716e68e4804dd65d22a9aee6777e:9:28741
o@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:53950
http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:54095
u@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:51:98901
ERROR: 'Unhandled promise rejection', TypeError: undefined is not an object (evaluating 'fileList.findFileEl')
http://localhost:9876/base/apps/files_trashbin/tests/js/filelistSpec.js?5fd90656cff4f49039c67b7230239608a2d9fa60:333:21
o@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:53950
http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:54095
u@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:51:98901
ERROR: 'Unhandled promise rejection', TypeError: undefined is not an object (evaluating 'fileList.findFileEl')
http://localhost:9876/base/apps/files_trashbin/tests/js/filelistSpec.js?5fd90656cff4f49039c67b7230239608a2d9fa60:371:21
o@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:53950
http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:54095
u@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:51:98901
ERROR: 'Unhandled promise rejection', TypeError: undefined is not an object (evaluating 'fileList.isEmpty')
http://localhost:9876/base/apps/files_trashbin/tests/js/filelistSpec.js?5fd90656cff4f49039c67b7230239608a2d9fa60:393:21
o@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:53950
http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:54095
u@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:51:98901
................................................................................
22 01 2019 12:31:25.555:WARN [web-server]: 404: /svg
...................22 01 2019 12:31:25.714:WARN [web-server]: 404: /svg
...........................
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Sharing.ShareBreadCrumbView tests Rendering Add link share to user share FAILED
Expected 1 to equal 0.
apps/files_sharing/tests/js/sharedbreadcrumviewSpec.js:235:54
Expected 0 to equal 1.
apps/files_sharing/tests/js/sharedbreadcrumviewSpec.js:237:54
......................................
ERROR: 'Unhandled promise rejection', TypeError: undefined is not an object (evaluating 'url.indexOf')
parseIdFromLocation@http://localhost:9876/base/core/js/oc-backbone-webdav.js?eb6c6fbf288c2521fa6d474b8d5ae163ee4eee2d:9:2145
parsePropFindResult@http://localhost:9876/base/core/js/oc-backbone-webdav.js?eb6c6fbf288c2521fa6d474b8d5ae163ee4eee2d:9:1904
http://localhost:9876/base/core/js/oc-backbone-webdav.js?eb6c6fbf288c2521fa6d474b8d5ae163ee4eee2d:9:4933
o@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:53950
http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:46:54095
u@http://localhost:9876/base/core/js/dist/main.js?5eb97d6cf4ea8eaa6eff53f9a2a9ca1ae5ce0ca2:51:98901
.................................................................
PhantomJS 2.1.1 (Linux 0.0.0): Executed 1067 of 1071 (1 FAILED) (skipped 4) (12.732 secs / 12.404 secs)

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr · 2019-01-22T14:57:45Z

Fixed the failing tests, however those Unhandled promise rejection messages appear on master as well: #13743

danxuliu

Tested and works 👍

Fixes #13056

rullzer · 2019-01-23T16:02:48Z

So this can go in?

danxuliu · 2019-01-23T16:51:03Z

So this can go in?

I think so.

backportbot-nextcloud · 2019-01-23T18:15:55Z

backport to stable15 in #13769

juliusknorr added bug 3. to review Waiting for reviews feature: files labels Jan 22, 2019

juliusknorr added this to the Nextcloud 16 milestone Jan 22, 2019

juliusknorr requested review from ChristophWurst, danxuliu, rullzer and skjnldsv January 22, 2019 12:15

backportbot-nextcloudBot added the backport-request label Jan 22, 2019

skjnldsv approved these changes Jan 22, 2019
View reviewed changes

rullzer approved these changes Jan 22, 2019
View reviewed changes

skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 22, 2019

skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jan 22, 2019

Call proper function when fetching link shares in the breadcrumb view
e5445cc
Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the bugfix/noid/link-share-breadcrumb branch from 49ded62 to e5445ccCompare January 22, 2019 14:56

danxuliu approved these changes Jan 23, 2019
View reviewed changes

skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jan 23, 2019

skjnldsv merged commit 31335f9 into masterJan 23, 2019

skjnldsv deleted the bugfix/noid/link-share-breadcrumb branch January 23, 2019 18:14

backportbot-nextcloudBot mentioned this pull request Jan 23, 2019
[stable15] Call proper function when fetching link shares in the breadcrumb view #13769
Merged

backportbot-nextcloudBot removed the backport-request label Jan 23, 2019

Navigation Menu

Uh oh!

Uh oh!

Call proper function when fetching link shares in the breadcrumb view - #13734

Call proper function when fetching link shares in the breadcrumb view#13734
skjnldsv merged 1 commit into
masterfrom
bugfix/noid/link-share-breadcrumb

juliusknorr commented Jan 22, 2019•
edited by skjnldsv
Loading

Uh oh!

juliusknorr commented Jan 22, 2019

Uh oh!

juliusknorr commented Jan 22, 2019

Uh oh!

skjnldsv left a comment

Uh oh!

rullzer left a comment

Uh oh!

skjnldsv commented Jan 22, 2019

Uh oh!

juliusknorr commented Jan 22, 2019

Uh oh!

danxuliu left a comment

Uh oh!

rullzer commented Jan 23, 2019

Uh oh!

danxuliu commented Jan 23, 2019

Uh oh!

backportbot-nextcloudBot commented Jan 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

juliusknorr commented Jan 22, 2019• edited by skjnldsv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliusknorr commented Jan 22, 2019

Uh oh!

juliusknorr commented Jan 22, 2019

Uh oh!

skjnldsv left a comment

Choose a reason for hiding this comment

Uh oh!

rullzer left a comment

Choose a reason for hiding this comment

Uh oh!

skjnldsv commented Jan 22, 2019

Uh oh!

juliusknorr commented Jan 22, 2019

Uh oh!

danxuliu left a comment

Choose a reason for hiding this comment

Uh oh!

rullzer commented Jan 23, 2019

Uh oh!

danxuliu commented Jan 23, 2019

Uh oh!

backportbot-nextcloudBot commented Jan 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

juliusknorr commented Jan 22, 2019•
edited by skjnldsv
Loading