Uh oh!
There was an error while loading. Please reload this page.
Honor remember_login_cookie_lifetime - #13747
Merged
rullzer merged 1 commit intoJan 23, 2019
Merged
Conversation
rullzer
requested review from
ChristophWurst, MorrisJobke, nickvergessen and schiessleJanuary 22, 2019 15:20
MorrisJobke
commented
Jan 23, 2019
Member
Phpunit failed |
If the remember_login_cookie_lifetime is set to 0 this means we do not want to use remember me at all. In that case we should also not creatae a remember me cookie and should create a proper temp token. Further this specifies that is not 0 the remember me time should always be larger than the session timeout. Because else the behavior is not really defined. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
fix/honor_session_lifetime_if_remember_cookie_is_disabled
branch
from
January 23, 2019 07:46
216aa81 to
e6333c8Comparerullzer
deleted the
fix/honor_session_lifetime_if_remember_cookie_is_disabled
branch
January 23, 2019 09:12
rullzer
commented
Jan 23, 2019
MemberAuthor
/backport to stable15 |
rullzer
commented
Jan 23, 2019
MemberAuthor
/backport to stable14 |
backport to stable15 in #13758 |
The backport to stable14 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the remember_login_cookie_lifetime is set to 0 this means we do not
want to use remember me at all. In that case we should also not create
a remember me cookie and should create a proper temp token.
Further this specifies that is not 0 the remember me time should always
be larger than the session timeout. Because else the behavior is not
really defined.