Skip to content

Update User_LDAP.php - #13755

Closed
sretika wants to merge 1 commit into
nextcloud:masterfrom
sretika:patch-1
Closed

Update User_LDAP.php#13755
sretika wants to merge 1 commit into
nextcloud:masterfrom
sretika:patch-1

Conversation

@sretika

Copy link
Copy Markdown

userManager->getAttributes() could be returning empty values, which will give no result when used for searching. This patch will simply drop empty values in the $attrs before using it for searching.

@rullzer
rullzer requested a review from blizzzJanuary 23, 2019 09:30
@rullzerrullzer added 3. to review Waiting for reviews feature: ldap labels Jan 23, 2019
@rullzerrullzer added this to the Nextcloud 16 milestone Jan 23, 2019
@violoncelloCH

Copy link
Copy Markdown
Member

DCO is failing because the commit is not signed-off
@sretika2 could you please sign your commit? - see https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work
can be done with git commit --amend -s for the last commit and then git push -f to push the changed commit back to github...

userManager->getAttributes() could be returning empty values, which will give no result when used for searching. This patch will simply drop empty values in the $attrs before using it for searching.
Signed-off-by: Samuel Retika <m_samuel_l@hotmail.com>
@sretika

Copy link
Copy Markdown
Author

Sure thing. Done.

@blizzz

Copy link
Copy Markdown
Member

@sretika2 it should not return empty attributes, cf. https://github.com/nextcloud/server/blob/master/apps/user_ldap/lib/User/Manager.php#L200-L205

@MorrisJobkeMorrisJobke mentioned this pull request Mar 4, 2019
45 tasks
@MorrisJobkeMorrisJobke removed this from the Nextcloud 16 milestone Mar 6, 2019
@MorrisJobkeMorrisJobke added this to the Nextcloud 17 milestone Mar 20, 2019
@MorrisJobkeMorrisJobke mentioned this pull request Jul 15, 2019
28 tasks
@MorrisJobke

Copy link
Copy Markdown
Member

As there is no feedback since a while I will close this ticket. If this is still a problem please feel free to reopen and explain what is happening in detail. Maybe together with some debug logs with the variable values.

@MorrisJobkeMorrisJobke removed this from the Nextcloud 17 milestone Jul 16, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: ldap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@sretika@violoncelloCH@blizzz@MorrisJobke@rullzer