Uh oh!
There was an error while loading. Please reload this page.
always use multipart uploader for s3 uploads - #13866
Merged
Merged
Conversation
the multipart uploader handles non seekable streams while `upload` does not Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
commented
Jan 28, 2019
MemberAuthor
did some quick "real life" testing, chunked uploads work as expected with this patch while they break on master |
icewind1991
commented
Jan 28, 2019
MemberAuthor
it might still be useful to look into making the assembly stream seekable, as I expect that that would lead to faster uploading than having the multipart uploader work around it |
Closed
Member
@icewind1991 Does this fix #13062? |
icewind1991
commented
Jan 28, 2019
MemberAuthor
yes |
rullzer
commented
Jan 29, 2019
Member
/backport to stable15 |
backport to stable15 in #13882 |
HLFH
commented
Feb 11, 2019
Contributor
@MorrisJobke@icewind1991 Hi. Does this PR fix #8275? |
MorrisJobke
commented
Feb 11, 2019
Member
Does not look like, because this PR fixes uploads while the linked issue is most likely about downloads of images. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the multipart uploader handles non seekable streams while
uploaddoes notFixes#13062