Uh oh!
There was an error while loading. Please reload this page.
Clean pending 2FA authentication on password reset - #13869
Merged
Conversation
rullzer
commented
Jan 28, 2019
MemberAuthor
/backport to stable15 |
rullzer
commented
Jan 28, 2019
MemberAuthor
/backport to stable14 |
rullzer
commented
Jan 28, 2019
MemberAuthor
/backport to stable13 |
MorrisJobke
approved these changes
Jan 28, 2019
MorrisJobke
commented
Jan 28, 2019
Member
Quite some CI failures in the |
rullzerforce-pushed
the
enh/clean_pending_2fa_session_on_password_change
branch
from
January 29, 2019 10:04
2e77a05 to
a4648c6CompareWhen a password is reste we should make sure that all users are properly logged in. Pending states should be cleared. For example a session where the 2FA code is not entered yet should be cleared. The token is now removed so the session will be killed the next time this is checked (within 5 minutes). Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
enh/clean_pending_2fa_session_on_password_change
branch
from
January 29, 2019 12:09
a4648c6 to
ac8a6e2CompareThe backport to stable15 failed. Please do this backport manually. |
The backport to stable14 failed. Please do this backport manually. |
The backport to stable13 failed. Please do this backport manually. |
This was referenced Jan 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a password is reste we should make sure that all users are properly
logged in. Pending states should be cleared. For example a session where
the 2FA code is not entered yet should be cleared.
The token is now removed so the session will be killed the next time
this is checked (within 5 minutes).
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl