Skip to content

Emit event to load additionalscripts - #13899

Merged
rullzer merged 1 commit into
masterfrom
enh/13662/events_to_load_additional_scripts
Jan 31, 2019
Merged

Emit event to load additionalscripts#13899
rullzer merged 1 commit into
masterfrom
enh/13662/events_to_load_additional_scripts

Conversation

@rullzer

@rullzerrullzer commented Jan 29, 2019

Copy link
Copy Markdown
Member

Fixes#13662

This will fire of an event after a Template Response has been returned.
There is an event for the generic loading and one when logged in. So
apps can chose to load only on loged in pages.

This is a more generic approach than the files app event. As some things
we might want to load on other pages as well besides the files app.

Todo:

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzerrullzer added enhancement 3. to review Waiting for reviews labels Jan 29, 2019
@rullzerrullzer added this to the Nextcloud 16 milestone Jan 29, 2019
@rullzerrullzer changed the title Emit to load additionalscriptsEmit event to load additionalscriptsJan 29, 2019

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and clean 👍

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@rullzer

Copy link
Copy Markdown
MemberAuthor

Then let me add some tests later today for the middleware. And then this can get in :)

Fixes#13662
This will fire of an event after a Template Response has been returned.
There is an event for the generic loading and one when logged in. So
apps can chose to load only on loged in pages.
This is a more generic approach than the files app event. As some things
we might want to load on other pages as well besides the files app.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzerforce-pushed the enh/13662/events_to_load_additional_scripts branch from 9450367 to d182037CompareJanuary 31, 2019 11:11
@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 31, 2019
@rullzer
rullzer merged commit 5c4ed02 into masterJan 31, 2019
@rullzer
rullzer deleted the enh/13662/events_to_load_additional_scripts branch January 31, 2019 11:56
@MorrisJobkeMorrisJobke mentioned this pull request Jul 13, 2020
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@ChristophWurst