Uh oh!
There was an error while loading. Please reload this page.
Fix folder drag glitch in Firefox - #1406
Conversation
issue: * drag'n'drop a folder into the files app in Firefox * the highlight stays there because Firefox doesn't trigger the drop event for folders solution: * behave like the drop event if the dragover event isn't fired for 100ms (only applied in Firefox)
mention-bot
commented
Sep 14, 2016
@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vincchan, @butonic and @luckydonald to be potential reviewers |
nickvergessen
commented
Sep 14, 2016
But the error message still doesnt come anymore? Can we create that as well manually? |
MorrisJobke
commented
Sep 14, 2016
This is not there in stable9 as well. I would make this an additional PR |
MorrisJobke
commented
Sep 14, 2016
also in stable8.2 there was no dialog. I also tried to get an event for the folder drop, but firefox doesn't trigger anything. I guess it simply isn't invoke by Firefox and we can't do much here. |
nickvergessen
commented
Sep 14, 2016
Just tested and yes, seems to indeed be broken a long time :( |
nickvergessen
commented
Sep 26, 2016
👍 |
nickvergessen
commented
Sep 26, 2016
Review @LukasReschke@MariusBluem |
LukasReschke
commented
Sep 26, 2016
LGTM |
MorrisJobke
commented
Sep 26, 2016
@nickvergessen I guess it's better to backport this to stable10, right? |
nickvergessen
commented
Sep 26, 2016
Yup, quite irritating otherwise |
issue:
solution:
cc @vincchan@rullzer@raghunayyar@LukasReschke