Uh oh!
There was an error while loading. Please reload this page.
Fix the thorrtler whitelist bitmask - #14149
Merged
Merged
Conversation
Before we actually didn't check each bit of the bitmask. Now we do. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst, MorrisJobke, juliusknorr and nickvergessenFebruary 11, 2019 22:24
kesselb
approved these changes
Feb 11, 2019
kesselb
reviewed
Feb 11, 2019
| $bitmask = 1 << (7 - ($i % 8)); | ||
| $part = $part & $bitmask; | ||
| $orig = $orig & $bitmask; |
Contributor
There was a problem hiding this comment.
$part &= $bitmask; and $orig &= $bitmask; would also work but is hard to read.
rullzer
commented
Feb 12, 2019
MemberAuthor
/backport to stable15 |
rullzer
commented
Feb 12, 2019
MemberAuthor
/backport to stable14 |
backport to stable15 in #14151 |
backport to stable14 in #14152 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we actually didn't check each bit of the bitmask. Now we do.
Testing is easy. Just try to run the added testcases without this patch.