Skip to content

Correctly determinate the owner in case of shared external storages - #14194

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/correctly-determinate-owner-in-case-of-shared-external-storages
Feb 19, 2019
Merged

Correctly determinate the owner in case of shared external storages#14194
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/correctly-determinate-owner-in-case-of-shared-external-storages

Conversation

@nickvergessen

@nickvergessennickvergessen commented Feb 14, 2019

Copy link
Copy Markdown
Member

Steps

  1. add an external storage
  2. created a file "shared.txt"
    i. user gets notified
  3. modified this file
    i. user gets notified
  4. shared it with another user (B)
    i. both users are getting notified
  5. user B modified this file
    i. only user B gets notified, not the creator

@nickvergessennickvergessen added this to the Nextcloud 16 milestone Feb 14, 2019
@nickvergessen

nickvergessen commented Feb 14, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@nickvergessen

nickvergessen commented Feb 14, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

rullzer
rullzer approved these changes Feb 14, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense.

MorrisJobke
MorrisJobke approved these changes Feb 14, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke

MorrisJobke commented Feb 14, 2019

Copy link
Copy Markdown
Member

Failing tests:

There were 2 errors:
1) Test\Share20\ManagerTest::testGetAccessList
Error: Call to a member function getUID() on null
/drone/src/github.com/nextcloud/server/lib/private/Share20/Manager.php:1427
/drone/src/github.com/nextcloud/server/tests/lib/Share20/ManagerTest.php:3506
2) Test\Share20\ManagerTest::testGetAccessListWithCurrentAccess
Error: Call to a member function getUID() on null
/drone/src/github.com/nextcloud/server/lib/private/Share20/Manager.php:1427
/drone/src/github.com/nextcloud/server/tests/lib/Share20/ManagerTest.php:3624

@nickvergessen
Correctly determinate the owner in case of shared external storages
f66c37b
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/correctly-determinate-owner-in-case-of-shared-external-storages branch from 7705aee to f66c37bCompareFebruary 18, 2019 09:57
@nickvergessen

nickvergessen commented Feb 18, 2019

Copy link
Copy Markdown
MemberAuthor

fixed

@MorrisJobke
MorrisJobke merged commit 30e7d3e into masterFeb 19, 2019
@MorrisJobke
MorrisJobke deleted the bugfix/noid/correctly-determinate-owner-in-case-of-shared-external-storages branch February 19, 2019 09:28
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 19, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 19, 2019

Copy link
Copy Markdown

backport to stable15 in #14283

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 19, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 19, 2019

Copy link
Copy Markdown

backport to stable14 in #14284

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsfeature: external storagefeature: sharing

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@MorrisJobke@rullzer