Skip to content

ensure attribute names are lower cased - #14200

Merged
blizzz merged 1 commit into
masterfrom
fix/noid/ldap-lowercase-request-attributes
Feb 14, 2019
Merged

ensure attribute names are lower cased#14200
blizzz merged 1 commit into
masterfrom
fix/noid/ldap-lowercase-request-attributes

Conversation

@blizzz

Copy link
Copy Markdown
Member

otherwise they will be skipped when the results is being formatted and the
lower-cased result keys do not match.

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@blizzz

Copy link
Copy Markdown
MemberAuthor

ah, let me quickly take out adding @property string homeFolderNamingRule to Connection.php as it probably creates a conflict with #14174

otherwise they will be skipped when the results is being formatted and the
lower-cased result keys do not match.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzzforce-pushed the fix/noid/ldap-lowercase-request-attributes branch from 743a813 to 5c10a46CompareFebruary 14, 2019 13:13
@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 14, 2019
@blizzz

Copy link
Copy Markdown
MemberAuthor

failing tests unrelated → merging

@blizzz
blizzz merged commit a80bae3 into masterFeb 14, 2019
@blizzz
blizzz deleted the fix/noid/ldap-lowercase-request-attributes branch February 14, 2019 14:06
@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable13

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #14203

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable14 failed. Please do this backport manually.

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable13 failed. Please do this backport manually.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: ldap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz@rullzer@juliusknorr@MorrisJobke