Skip to content

Move updatenotifications to unified webpack - #14232

Merged
MorrisJobke merged 1 commit into
masterfrom
enh/updatenoticiation_to_single_webpack
Feb 19, 2019
Merged

Move updatenotifications to unified webpack#14232
MorrisJobke merged 1 commit into
masterfrom
enh/updatenoticiation_to_single_webpack

Conversation

@rullzer

Copy link
Copy Markdown
Member

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@juliusknorr
juliusknorrforce-pushed the enh/updatenoticiation_to_single_webpack branch from 4abaca6 to 184bcacCompareFebruary 16, 2019 14:09
@juliusknorr

Copy link
Copy Markdown
Member

@rullzer I've pushed better a fix for the hot reload issue, which causes differences in the bundled files. The actual issue is that webpack doesn't set the NODE_ENV variable when setting the mode to 'production' so vue-loader was still behaving as if it was in development mode. (https://github.com/webpack/webpack/issues/7074) Setting the environment variable as well seems to fix that: b6335e9

@skjnldsv

Copy link
Copy Markdown
Member

@juliushaertl does this impact the bundle size ? Shall we edit all of our configs?

@rullzerrullzer mentioned this pull request Feb 17, 2019
@rullzer

Copy link
Copy Markdown
MemberAuthor

@juliushaertl nice catch. Lets fix this in a seperate PR so we keep it clean. See #14258

@juliusknorr

Copy link
Copy Markdown
Member

@juliushaertl does this impact the bundle size ? Shall we edit all of our configs?

I didn't found any huge difference, for the server bundles it was like <1kb less.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzerforce-pushed the enh/updatenoticiation_to_single_webpack branch from 184bcac to d6ba420CompareFebruary 18, 2019 12:23
@rullzer

Copy link
Copy Markdown
MemberAuthor

Rebased. Ready to get in!

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 19, 2019
@MorrisJobke
MorrisJobke merged commit ef4e7d0 into masterFeb 19, 2019
@MorrisJobke
MorrisJobke deleted the enh/updatenoticiation_to_single_webpack branch February 19, 2019 09:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementjavascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@juliusknorr@skjnldsv@MorrisJobke