Uh oh!
There was an error while loading. Please reload this page.
Fix ocm end-point discovery discovery - #14255
Conversation
TODO:
|
schiessle
commented
Feb 18, 2019
@rullzer updated the documentation as well: nextcloud/documentation#1260 |
rullzer
commented
Feb 18, 2019
@MorrisJobke just editing it there is enough to also trigger the recreation of htacceess during update right? |
MorrisJobke
commented
Feb 19, 2019
Please add a setup check to the admin settings to notify users about this. See for example the well-known check in the browser that does something like this: Line 251 in 813ff43 |
MorrisJobke
commented
Feb 19, 2019
It is written on every update - so yes. |
schiessle
commented
Feb 19, 2019
@MorrisJobke seems like we don't have a similar check for the "ocs-provider" endpoint as well. I'm not sure how to add this quickly. Maybe some of our @nextcloud/javascript experts? |
schiessle
commented
Feb 19, 2019
I added a check for both (while I'm on it), the ocs-provider and the ocm-provider route, see the last two commits |
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
…ected to the index.php Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Uh oh!
There was an error while loading. Please reload this page.
MorrisJobke
commented
Feb 20, 2019
And let me also rebase to resolve conflicts ... |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
schiessle
commented
Feb 20, 2019
@MorrisJobke thanks for taking care of it! 👍 |
MorrisJobke
commented
Feb 20, 2019
And let me add some unit tests for it. |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
b980890 to
faef057CompareMorrisJobke
commented
Feb 20, 2019
/backport to stable15 |
The backport to stable15 failed. Please do this backport manually. |
MorrisJobke
commented
Feb 20, 2019
Backport in #14312 |
MorrisJobke
commented
Mar 5, 2019
@schiessle Is there any reason why this is not put under the |
fix#14247