Uh oh!
There was an error while loading. Please reload this page.
Warning if x-forwarded-host present but trusted_proxies empty - #14261
Merged
MorrisJobke merged 1 commit intoFeb 19, 2019
Merged
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
show-warning-if-x-forwarded-set-with-empty-trusted-proxies
branch
from
February 17, 2019 22:53
2571080 to
600bc22CompareMorrisJobke
commented
Feb 19, 2019
Member
I failure unrelated. |
MorrisJobke
deleted the
show-warning-if-x-forwarded-set-with-empty-trusted-proxies
branch
February 19, 2019 09:32
This was referenced Apr 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you run nextcloud behind a reverse proxy then usually X-Forwarded-Host is present:
I've decided against X-Forwarded-For because this will cause a false positive on plesk hosting (nginx in front of apache: https://docs.plesk.com/en-US/onyx/administrator-guide/web-servers/apache-and-nginx-web-servers-linux/apache-with-nginx.70837/)
cc @J0WI will show a warning to docker users with an invalid setup (empty trusted proxies).