Uh oh!
There was an error while loading. Please reload this page.
Handle writestream not closing source - #14299
Merged
Merged
Conversation
Fixes#14298 If a storage doesn'tclose the write stream then $isEOF is not yet set. So we have to fallback. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
commented
Feb 20, 2019
MemberAuthor
/backport to stable15 |
MorrisJobke
approved these changes
Feb 20, 2019
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Code looks good and makes sense 👍
tobiasKaminsky
commented
Feb 20, 2019
Member
Works on local Android's test. |
tobiasKaminsky
approved these changes
Feb 20, 2019
The backport to stable15 failed. Please do this backport manually. |
MorrisJobke
commented
Feb 20, 2019
Member
This looks good on stable15: server/apps/dav/lib/Connector/Sabre/File.php Lines 171 to 173 in 3525192 No need to backport it. |
rullzer
commented
Feb 20, 2019
MemberAuthor
Yeah it is but after #14273 😉 |
MorrisJobke
commented
Feb 20, 2019
Member
Then let me add it to that PR. |
2 tasks
MorrisJobke
commented
Feb 20, 2019
Member
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#14298
If a storage doesn'tclose the write stream then $isEOF is not yet set.
So we have to fallback.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl