Skip to content

Fix unsafe array access - #14332

Merged
rullzer merged 1 commit into
masterfrom
bugfix/13098-unsafe-array-access
Feb 22, 2019
Merged

Fix unsafe array access #14332
rullzer merged 1 commit into
masterfrom
bugfix/13098-unsafe-array-access

Conversation

@kesselb

@kesselbkesselb commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

Close#13098

I see this on my instance but cannot reproduce 🙈

@kesselbkesselb added this to the Nextcloud 16 milestone Feb 21, 2019
nickvergessen
nickvergessen requested changes Feb 22, 2019
View reviewed changes
Comment threadapps/admin_audit/lib/Actions/Console.php Outdated
@nickvergessen

nickvergessen commented Feb 22, 2019

Copy link
Copy Markdown
Member

Can easily reproduce, just run sudo -u www-data occ with nothing else 🙈
I think we shouldn't log this, so my code suggestion.

@kesselb
Check if array element is present before access
268c0d9
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the bugfix/13098-unsafe-array-access branch from c25b99f to 268c0d9CompareFebruary 22, 2019 10:48
@kesselb

kesselb commented Feb 22, 2019

Copy link
Copy Markdown
ContributorAuthor

Can easily reproduce, just run sudo -u www-data occ with nothing else see_no_evil
I think we shouldn't log this, so my code suggestion.

👍 can reproduce now. admin_audit was broken somehow. your suggestion make sense. no need to log occ without arguments.

@nickvergessen

nickvergessen commented Feb 22, 2019

Copy link
Copy Markdown
Member

/backport to stable15

@rullzer
rullzer merged commit 9b15470 into masterFeb 22, 2019
@rullzer
rullzer deleted the bugfix/13098-unsafe-array-access branch February 22, 2019 11:52
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 22, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 22, 2019

Copy link
Copy Markdown

backport to stable15 in #14340

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@kesselb@nickvergessen@rullzer