Uh oh!
There was an error while loading. Please reload this page.
Search sharees on lookup server when explicitly requested by user - #14333
Merged
Conversation
jancborchardt
commented
Feb 22, 2019
Member
For the record here’s the mockup :) Btw @ChristophWurst, seems some unrelated files were edited maybe in the fixup?
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChristophWurst
commented
Feb 25, 2019
MemberAuthor
There seem to be a few UI hiccups here and there (already seen when working on #14180, hence this might be an old bug) but this generally works and also looks like @jancborchardt's mockup. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChristophWurstforce-pushed
the
feature/sharee-explicit-lookup
branch
from
February 25, 2019 15:30
bbde099 to
ce55388CompareChristophWurst
commented
Feb 25, 2019
MemberAuthor
Thanks for testing! 🙌 I squashed my fixup commits and rebased onto master. |
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChristophWurstforce-pushed
the
feature/sharee-explicit-lookup
branch
2 times, most recently
from
February 26, 2019 08:45
4ee34cf to
4533360Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChristophWurst
commented
Feb 26, 2019
MemberAuthor
Aaaaaaah now CI looks good :) Let me do a final squash&rebase |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurstforce-pushed
the
feature/sharee-explicit-lookup
branch
from
February 26, 2019 18:45
b9a5de0 to
e930a0cCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Before
Sharee search either never or always goes to lookup server, depending on admin setting.
Now
Sharee search by default just searches locally. If no results are returned and the lookup server is not explicitly disabled by the admin, the user gets the option to search globally. This retriggers the search request but also includes lookup server results.
Note: I had some difficulties connection to the lookup server form my dev server but the default empty response for that is sufficient for testing :)
Todo