Add test for updated CA bundle

[MorrisJobke]

For #14369

[MorrisJobke]

/backport to stable15

[MorrisJobke]

/backport to stable14

[kesselb]

https://curl.haxx.se/docs/caextract.html

I guess they are not to happy if you fetch the file multiple times a day. There are some recommendations at "Automated downloads from here".

[MorrisJobke]

I guess they are not to happy if you fetch the file multiple times a day. There are some recommendations at "Automated downloads from here".

Problem is that the mtime is "now" when doing a fresh git clone. Let me have a look into this.

[MorrisJobke]

I guess they are not to happy if you fetch the file multiple times a day. There are some recommendations at "Automated downloads from here".

Problem is that the mtime is "now" when doing a fresh git clone. Let me have a look into this.

Any other ideas? :/

[kesselb]

• Mirror cacert.pem and cacert.pem.sha256 to *.nextcloud.com and fetch it from there?
• Run only if branch name is version/noid/*? (not sure if possible but should be available https://0-8-0.docs.drone.io/environment-reference/)
• Write a cacertbot (could be useful for other projects)

[MorrisJobke]

• Run only if branch name is version/noid/*? (not sure if possible but should be available https://0-8-0.docs.drone.io/environment-reference/)

That one makes most sense 👍

[MorrisJobke]

Makes sense 👍

[kesselb]

https://drone.nextcloud.com/nextcloud/server/16761/86 (branch name: ci/noid/add-bundle-test) ✔️

[MorrisJobke]

Bundle properly skipped - let me rebase for squash all the commits in here.

[MorrisJobke]

@kesselb Ready for final review 👍

[kesselb]

https://drone.nextcloud.com/nextcloud/server/16769/86

Looks like $DRONE_BRANCH is the target branch. We can either check against DRONE_REFSPEC for version/noid/ or check if DRONE_BRANCH is stable(\d){2}.

[kesselb]

DRONE_BRANCH is stable(\d){2}.

Not an option because this is true for every backport ... 👿

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16776: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

• tests/acceptance/features/app-files.feature:97

Show full log

 Scenario: show favorites for a second time # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:97
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I open the "Favorites" section # AppNavigationContext::iOpenTheSection()
And I see that the current section is "Favorites" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
And I open the "All files" section # AppNavigationContext::iOpenTheSection()
And I see that the current section is "All files" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
When I open the "Favorites" section # AppNavigationContext::iOpenTheSection()
Then I see that the current section is "Favorites" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link

• tests/acceptance/features/app-files-sharing-link.feature:128

Show full log

 Scenario: access a shared link protected by password with an invalid password # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:128
Given I act as John # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I share the link for "welcome.txt" protected by the password "abcdef" # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
Share action for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I write down the shared link # FilesAppSharingContext::iWriteDownTheSharedLink()
When I act as Jane # ActorContext::iActAs()
And I visit the shared link I wrote down # PublicShareContext::iVisitTheSharedLinkIWroteDown()
And I authenticate with password "fedcba" # PublicShareContext::iAuthenticateWithPassword()
Then I see that the current page is the Authenticate page for the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
And I see that a wrong password for the shared file message is shown # PublicShareContext::iSeeThatAWrongPasswordForTheSharedFileMessageIsShown()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-tags

• tests/acceptance/features/app-files-tags.feature:70

Show full log

 Scenario: remove tags using the dropdown in the details view # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-tags.feature:70
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage()
And I open the "Tag management" section # AppNavigationContext::iOpenTheSection()
And I see that the button to select tags is shown # SettingsContext::iSeeThatTheButtonToSelectTagsIsShown()
And I create the tag "tag1" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I create the tag "tag2" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I create the tag "tag3" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I create the tag "tag4" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I see that the dropdown for tags in the settings eventually contains the tag "tag1" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I see that the dropdown for tags in the settings eventually contains the tag "tag2" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I see that the dropdown for tags in the settings eventually contains the tag "tag3" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I see that the dropdown for tags in the settings eventually contains the tag "tag4" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I log out # SettingsMenuContext::iLogOut()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
And I open the input field for tags in the details view # FilesAppContext::iOpenTheInputFieldForTagsInTheDetailsView()
And I check the tag "tag2" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView()
And I check the tag "tag4" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView()
And I check the tag "tag3" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView()
When I uncheck the tag "tag2" in the dropdown for tags in the details view # FilesAppContext::iUncheckTheTagInTheDropdownForTagsInTheDetailsView()
And I uncheck the tag "tag4" in the dropdown for tags in the details view # FilesAppContext::iUncheckTheTagInTheDropdownForTagsInTheDetailsView()
Then I see that the tag "tag2" in the dropdown for tags in the details view is not checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsNotChecked()
And I see that the tag "tag4" in the dropdown for tags in the details view is not checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsNotChecked()
And I see that the tag "tag3" in the dropdown for tags in the details view is checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked()
And I see that the input field for tags in the details view does not contain the tag "tag2" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewDoesNotContainTheTag()
Failed asserting that false is true.
And I see that the input field for tags in the details view does not contain the tag "tag4" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewDoesNotContainTheTag()
And I see that the input field for tags in the details view contains the tag "tag3" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewContainsTheTag()

TESTS=acceptance, TESTS-ACCEPTANCE=login

• tests/acceptance/features/login.feature:38

Show full log

 Scenario: log in with invalid user once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:38
Given I act as John # ActorContext::iActAs()
And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
When I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I create user unknownUser with password 123456acb # UsersSettingsContext::iCreateUserWithPassword()
And I see that the list of users contains the user unknownUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I act as John # ActorContext::iActAs()
And I log in with user unknownUser and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()
Then I see that the current page is the Files app # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()
Failed asserting that 'http://acceptance-login/index.php/login?user=unknownUser' starts with "http://acceptance-login/index.php/apps/files/".

TESTS=acceptance, TESTS-ACCEPTANCE=users

• tests/acceptance/features/users.feature:13
• tests/acceptance/features/users.feature:25
• tests/acceptance/features/users.feature:35
• tests/acceptance/features/users.feature:47

Show full log

 Scenario: create a new user with a custom display name # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:13
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
When I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I set the user name for the new user to "test" # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
And I set the password for the new user to "123456acb" # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
And I create the new user # UsersSettingsContext::iCreateTheNewUser()
Then I see that the list of users contains the user "test" # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I see that the display name for the user "test" is "Test display name" # UsersSettingsContext::iSeeThatTheDisplayNameForTheUserIs()
Row for user test in Users Settings could not be found after 100 seconds
displayName cell for user test in Users Settings could not be found after 100 seconds
displayName input for user test in Users Settings could not be found after 100 seconds (NoSuchElementException)
Scenario: delete a user # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:25
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Delete user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Delete user" action in the user0 actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the list of users does not contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
Scenario: disable a user # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:35
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Disable user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Disable user" action in the user0 actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the list of users does not contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
When I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
Then I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
Scenario: users navigation without disabled users # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:47
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
And I see that the list of users contains the user disabledUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user disabledUser # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Enable user" action in the disabledUser actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()
When I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16778: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

• tests/acceptance/features/app-comments.feature:56

Show full log

 Scenario: read a comment written by the sharee # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-comments.feature:56
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as John # ActorContext::iActAs()
And I rename "welcome.txt" to "shared.txt" # FileListContext::iRenameTo()
And I share "shared.txt" with "user0" # FilesAppSharingContext::iShareWith()
Share action for file shared.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I open the details view for "shared.txt" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
When I act as John # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I open the details view for "shared.txt" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
Then I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

• tests/acceptance/features/app-files.feature:154

Show full log

 Scenario: move a selection to another folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:154
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
│ Create menu button in file list could not be clicked
│ Exception message: Element is not currently visible and so may not be interacted with
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: '28989b87ef96', ip: '172.17.0.7', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-43-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ And I create a new folder named "Not selected folder" # FileListContext::iCreateANewFolderNamed()
And I create a new folder named "Destination" # FileListContext::iCreateANewFolderNamed()
When I select "welcome.txt" # FileListContext::iSelect()
And I select "Folder" # FileListContext::iSelect()
And I start the move or copy operation for the selected files # FileListContext::iStartTheMoveOrCopyOperationForTheSelectedFiles()
And I select "Destination" in the file picker # FilePickerContext::iSelectInTheFilePicker()
Row for file Destination in the file picker dialog could not be found after 100 seconds (NoSuchElementException)
And I move to the last selected folder in the file picker # FilePickerContext::iMoveToTheLastSelectedFolderInTheFilePicker()
Then I see that the file list does not contain a file named "welcome.txt" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
And I see that the file list does not contain a file named "Folder" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
And I see that the file list contains a file named "Not selected folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I enter in the folder named "Destination" # FileListContext::iEnterInTheFolderNamed()
And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I see that the file list contains a file named "Folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I see that the file list does not contain a file named "Not selected folder" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing

• tests/acceptance/features/app-files-sharing.feature:59
• tests/acceptance/features/app-files-sharing.feature:170

Show full log

 Scenario: reshare a file with another user # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing.feature:59
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as Jim # ActorContext::iActAs()
And I am logged in as "user1" # LoginPageContext::iAmLoggedInAs()
And I act as John # ActorContext::iActAs()
And I rename "welcome.txt" to "farewell.txt" # FileListContext::iRenameTo()
And I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Row for file farewell.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I share "farewell.txt" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I share "farewell.txt" with "user1" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user1" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jim # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
Then I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I open the details view for "farewell.txt" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I open the "Sharing" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
And I see that the file is shared with me by "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()
sh: 1: kill: No such process
Scenario: resharee sees a folder created by the owner in a shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing.feature:170
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as Jim # ActorContext::iActAs()
And I am logged in as "user1" # LoginPageContext::iAmLoggedInAs()
And I act as John # ActorContext::iActAs()
And I create a new folder named "Shared folder" # FileListContext::iCreateANewFolderNamed()
And I see that the file list contains a file named "Shared folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I share "Shared folder" with "user0" # FilesAppSharingContext::iShareWith()
Share action for file Shared folder in file list could not be found after 100 seconds (NoSuchElementException)
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I share "Shared folder" with "user1" # FilesAppSharingContext::iShareWith()
And I act as John # ActorContext::iActAs()
And I enter in the folder named "Shared folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Subfolder" # FileListContext::iCreateANewFolderNamed()
And I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
When I act as Jim # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I enter in the folder named "Shared folder" # FileListContext::iEnterInTheFolderNamed()
Then I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

TESTS=acceptance, TESTS-ACCEPTANCE=login

• tests/acceptance/features/login.feature:15
• tests/acceptance/features/login.feature:38

Show full log

 Scenario: log in with valid user and invalid password once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:15
Given I act as John # ActorContext::iActAs()
And I can not log in with user user0 and password 654231 # LoginPageContext::iCanNotLogInWithUserAndPassword()
When I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I set the password for user0 to 654321 # UsersSettingsContext::iSetTheFieldForUserTo()
And I act as John # ActorContext::iActAs()
And I log in with user user0 and password 654321 # LoginPageContext::iLogInWithUserAndPassword()
Then I see that the current page is the Files app # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()
Failed asserting that 'http://acceptance-login/index.php/login?user=user0' starts with "http://acceptance-login/index.php/apps/files/".
Scenario: log in with invalid user once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:38
Given I act as John # ActorContext::iActAs()
And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
When I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I create user unknownUser with password 123456acb # UsersSettingsContext::iCreateUserWithPassword()
And I see that the list of users contains the user unknownUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I act as John # ActorContext::iActAs()
And I log in with user unknownUser and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()
Then I see that the current page is the Files app # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()
Failed asserting that 'http://acceptance-login/index.php/login?user=unknownUser' starts with "http://acceptance-login/index.php/apps/files/".

TESTS=acceptance, TESTS-ACCEPTANCE=users

• tests/acceptance/features/users.feature:13
• tests/acceptance/features/users.feature:25
• tests/acceptance/features/users.feature:35
• tests/acceptance/features/users.feature:47

Show full log

 Scenario: create a new user with a custom display name # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:13
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
When I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I set the user name for the new user to "test" # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
And I set the password for the new user to "123456acb" # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
And I create the new user # UsersSettingsContext::iCreateTheNewUser()
Then I see that the list of users contains the user "test" # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I see that the display name for the user "test" is "Test display name" # UsersSettingsContext::iSeeThatTheDisplayNameForTheUserIs()
Row for user test in Users Settings could not be found after 100 seconds
displayName cell for user test in Users Settings could not be found after 100 seconds
displayName input for user test in Users Settings could not be found after 100 seconds (NoSuchElementException)
Scenario: delete a user # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:25
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Delete user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Delete user" action in the user0 actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the list of users does not contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
Scenario: disable a user # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:35
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Disable user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Disable user" action in the user0 actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the list of users does not contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
When I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
Then I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
Scenario: users navigation without disabled users # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:47
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
And I see that the list of users contains the user disabledUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user disabledUser # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Enable user" action in the disabledUser actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()
When I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()

[kesselb]

https://drone.nextcloud.com/nextcloud/server/16778/86 looks good. checker executed for version/noid/xxx

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16777: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

• tests/acceptance/features/app-files.feature:41
• tests/acceptance/features/app-files.feature:97
• tests/acceptance/features/app-files.feature:144

Show full log

 Scenario: viewing a favorite file in its folder shows the correct sidebar view # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:41
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "other" # FileListContext::iCreateANewFolderNamed()
And I mark "other" as favorite # FileListContext::iMarkAsFavorite()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "other" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I open the "Favorites" section # AppNavigationContext::iOpenTheSection()
And I open the details view for "other" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "other" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
When I view "welcome.txt" in folder # FileListContext::iViewInFolder()
Row for file welcome.txt in file list could not be found after 100 seconds
File actions menu button for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
Then I see that the current section is "All files" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "welcome.txt" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
When I open the details view for "other" # FileListContext::iOpenTheDetailsViewFor()
And I see that the file name shown in the details view is "other" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
Scenario: show favorites for a second time # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:97
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I open the "Favorites" section # AppNavigationContext::iOpenTheSection()
And I see that the current section is "Favorites" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
And I open the "All files" section # AppNavigationContext::iOpenTheSection()
And I see that the current section is "All files" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
When I open the "Favorites" section # AppNavigationContext::iOpenTheSection()
Then I see that the current section is "Favorites" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
Scenario: move a file to another folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:144
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Destination" # FileListContext::iCreateANewFolderNamed()
When I start the move or copy operation for "welcome.txt" # FileListContext::iStartTheMoveOrCopyOperationFor()
And I select "Destination" in the file picker # FilePickerContext::iSelectInTheFilePicker()
Row for file Destination in the file picker dialog could not be found after 100 seconds (NoSuchElementException)
And I move to the last selected folder in the file picker # FilePickerContext::iMoveToTheLastSelectedFolderInTheFilePicker()
Then I see that the file list does not contain a file named "welcome.txt" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
And I enter in the folder named "Destination" # FileListContext::iEnterInTheFolderNamed()
And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

TESTS=acceptance, TESTS-ACCEPTANCE=login

• tests/acceptance/features/login.feature:38

Show full log

 Scenario: log in with invalid user once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:38
Given I act as John # ActorContext::iActAs()
And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
When I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I create user unknownUser with password 123456acb # UsersSettingsContext::iCreateUserWithPassword()
And I see that the list of users contains the user unknownUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I act as John # ActorContext::iActAs()
And I log in with user unknownUser and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()
Then I see that the current page is the Files app # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()
Failed asserting that 'http://acceptance-login/index.php/login?user=unknownUser' starts with "http://acceptance-login/index.php/apps/files/".

TESTS=acceptance, TESTS-ACCEPTANCE=users

• tests/acceptance/features/users.feature:13
• tests/acceptance/features/users.feature:25
• tests/acceptance/features/users.feature:35
• tests/acceptance/features/users.feature:47

Show full log

 Scenario: create a new user with a custom display name # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:13
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
When I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I set the user name for the new user to "test" # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
And I set the password for the new user to "123456acb" # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
And I create the new user # UsersSettingsContext::iCreateTheNewUser()
Then I see that the list of users contains the user "test" # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I see that the display name for the user "test" is "Test display name" # UsersSettingsContext::iSeeThatTheDisplayNameForTheUserIs()
Row for user test in Users Settings could not be found after 100 seconds
displayName cell for user test in Users Settings could not be found after 100 seconds
displayName input for user test in Users Settings could not be found after 100 seconds (NoSuchElementException)
Scenario: delete a user # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:25
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Delete user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Delete user" action in the user0 actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the list of users does not contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
Scenario: disable a user # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:35
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Disable user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Disable user" action in the user0 actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the list of users does not contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
When I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
Then I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
Scenario: users navigation without disabled users # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:47
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
And I see that the list of users contains the user disabledUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user disabledUser # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Enable user" action in the disabledUser actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()
When I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()

[MorrisJobke]

Then let's merge it.

👍 From my side for your code.

[backportbot-nextcloud]

backport to stable15 in #14546

[backportbot-nextcloud]

backport to stable14 in #14547