Skip to content

Add setup check for missing UTF8MB4 on mysql - #14398

Merged
MorrisJobke merged 1 commit into
masterfrom
feature/14394/add-setup-check-for-mysql-utf8mb4
Feb 28, 2019
Merged

Add setup check for missing UTF8MB4 on mysql#14398
MorrisJobke merged 1 commit into
masterfrom
feature/14394/add-setup-check-for-mysql-utf8mb4

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

See #14394 (comment)

Looks then like this:

bildschirmfoto 2019-02-27 um 10 10 46

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt test, but looks good

@MorrisJobke
MorrisJobkeforce-pushed the feature/14394/add-setup-check-for-mysql-utf8mb4 branch from e0c9690 to 3a6d3b8CompareFebruary 27, 2019 10:53
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 27, 2019
@rullzer

Copy link
Copy Markdown
Member

CI not happy

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

CI not happy

I know, but I have no idea why - it works locally just fine :/

@MorrisJobke

MorrisJobke commented Feb 28, 2019

Copy link
Copy Markdown
MemberAuthor

Unrelated failures - let me squash this then:

Status of 16578: failure

  • failure TESTS=acceptance, TESTS-ACCEPTANCE=app-files-tags
    • tests/acceptance/features/app-files-tags.feature:42
Show full log
 Scenario: add tags using the dropdown in the details view # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-tags.feature:42
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage()
And I open the "Tag management" section # AppNavigationContext::iOpenTheSection()
And I see that the button to select tags is shown # SettingsContext::iSeeThatTheButtonToSelectTagsIsShown()
And I create the tag "tag1" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I create the tag "tag2" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I create the tag "tag3" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I create the tag "tag4" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I see that the dropdown for tags in the settings eventually contains the tag "tag1" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I see that the dropdown for tags in the settings eventually contains the tag "tag2" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I see that the dropdown for tags in the settings eventually contains the tag "tag3" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I see that the dropdown for tags in the settings eventually contains the tag "tag4" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I log out # SettingsMenuContext::iLogOut()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
And I open the input field for tags in the details view # FilesAppContext::iOpenTheInputFieldForTagsInTheDetailsView()
When I check the tag "tag2" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView()
And I check the tag "tag4" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView()
Then I see that the tag "tag2" in the dropdown for tags in the details view is checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked()
And I see that the tag "tag4" in the dropdown for tags in the details view is checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked()
And I see that the input field for tags in the details view contains the tag "tag2" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewContainsTheTag()
Failed asserting that false is true.
And I see that the input field for tags in the details view contains the tag "tag4" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewContainsTheTag()
  • failure TESTS=acceptance, TESTS-ACCEPTANCE=users
    • tests/acceptance/features/users.feature:100
Show full log
 Scenario: change columns visibility # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:100
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the settings # AppSettingsContext::iOpenTheSettings()
App settings could not be found
The button to open the app settings could not be found (NoSuchElementException)
And I see that the settings are opened # AppSettingsContext::iSeeThatTheSettingsAreOpened()
When I toggle the showLanguages checkbox in the settings # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
Then I see that the "Language" column is shown # UsersSettingsContext::iSeeThatTheColumnIsShown()
When I toggle the showLastLogin checkbox in the settings # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
Then I see that the "Last login" column is shown # UsersSettingsContext::iSeeThatTheColumnIsShown()
When I toggle the showStoragePath checkbox in the settings # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
Then I see that the "Storage location" column is shown # UsersSettingsContext::iSeeThatTheColumnIsShown()
When I toggle the showUserBackend checkbox in the settings # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
Then I see that the "User backend" column is shown # UsersSettingsContext::iSeeThatTheColumnIsShown()
sh: 1: kill: No such process

@MorrisJobke
MorrisJobkeforce-pushed the feature/14394/add-setup-check-for-mysql-utf8mb4 branch from 113527b to 6c7ccbeCompareFebruary 28, 2019 15:45
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@ghost

Copy link
Copy Markdown

🎉

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Failures are unrelated.

@MorrisJobke
MorrisJobke merged commit 4880461 into masterFeb 28, 2019
@MorrisJobke
MorrisJobke deleted the feature/14394/add-setup-check-for-mysql-utf8mb4 branch February 28, 2019 21:39
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #14857

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@rullzer@nickvergessen@skjnldsv