Check if password can be changed for the users backend in OCS api

[juliusknorr]

Otherwise changing the password via the OCS api will return a success status, even if the password change is not supported by the user backend.

[juliusknorr]

/backport to stable15

[juliusknorr]

/backport to stable14

[rullzer]

Didn't even remember we allowed this via OCS...

anyway... makes sense.

[rullzer]

CI not happy

[skjnldsv]

CI not happy

@MorrisJobke we need a grumpy cat gif when ci is not happy pls

[rullzer]

@juliushaertl seem the provisioning API edit user tests is not happy...

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16759: failure

• TESTS=acceptance, TESTS-ACCEPTANCE=app-comments
  • tests/acceptance/features/app-comments.feature:10

Show full log

 Scenario: open the comments for a different file # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-comments.feature:10
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
When I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
Then I see that there are no comments # CommentsAppContext::iSeeThatThereAreNoComments()
The no comments message is not visible yet after 100 seconds

• TESTS=acceptance, TESTS-ACCEPTANCE=login
  • tests/acceptance/features/login.feature:38

Show full log

 Scenario: log in with invalid user once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:38
Given I act as John # ActorContext::iActAs()
And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
When I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I create user unknownUser with password 123456acb # UsersSettingsContext::iCreateUserWithPassword()
And I see that the list of users contains the user unknownUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I act as John # ActorContext::iActAs()
And I log in with user unknownUser and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()
Then I see that the current page is the Files app # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()
Failed asserting that 'http://acceptance-login/index.php/login?user=unknownUser' starts with "http://acceptance-login/index.php/apps/files/".

• TESTS=acceptance, TESTS-ACCEPTANCE=users
  • tests/acceptance/features/users.feature:13
  • tests/acceptance/features/users.feature:25
  • tests/acceptance/features/users.feature:35
  • tests/acceptance/features/users.feature:47

Show full log

 Scenario: create a new user with a custom display name # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:13
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
When I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I set the user name for the new user to "test" # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
And I set the password for the new user to "123456acb" # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
And I create the new user # UsersSettingsContext::iCreateTheNewUser()
Then I see that the list of users contains the user "test" # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I see that the display name for the user "test" is "Test display name" # UsersSettingsContext::iSeeThatTheDisplayNameForTheUserIs()
Row for user test in Users Settings could not be found after 100 seconds
displayName cell for user test in Users Settings could not be found after 100 seconds
displayName input for user test in Users Settings could not be found after 100 seconds (NoSuchElementException)
Scenario: delete a user # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:25
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Delete user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Delete user" action in the user0 actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the list of users does not contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
Scenario: disable a user # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:35
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Disable user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Disable user" action in the user0 actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the list of users does not contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
When I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
Then I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
Scenario: users navigation without disabled users # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:47
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
And I see that the list of users contains the user disabledUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user disabledUser # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Enable user" action in the disabledUser actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()
When I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()

[MorrisJobke]

Failures are "fixed" in #14541

[backportbot-nextcloud]

backport to stable15 in #14542

[backportbot-nextcloud]

backport to stable14 in #14543