Skip to content

Use node API for trash bin with special flag for getSize() - #14454

Merged
rullzer merged 2 commits into
masterfrom
feature/noid/use-node-api-for-trashbin
Mar 1, 2019
Merged

Use node API for trash bin with special flag for getSize()#14454
rullzer merged 2 commits into
masterfrom
feature/noid/use-node-api-for-trashbin

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

…al storage (doesn't count towards quota)"
This reverts commit e806aa6.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

This fixes #10862 on master

@rullzer
rullzer merged commit d0d1c85 into masterMar 1, 2019
@rullzer
rullzer deleted the feature/noid/use-node-api-for-trashbin branch March 1, 2019 12:22
@felixn

Copy link
Copy Markdown

Looks good to me.

Is it safe to make the same changes (i.e. switch to the node API) in the files_versions app?

$files_view = newView('/' . $uid . '/files');
$rootInfo = $files_view->getFileInfo('/', false);
$free = $quota - $rootInfo['size']; // remaining free space for user

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Is it safe to make the same changes (i.e. switch to the node API) in the files_versions app?

I would say so. 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@felixn@rullzer@icewind1991