Fix/users and groups/vue multiselect

[skjnldsv]

Design fixes

[ChristophWurst]

Design fixes

Please elaborate :)

[skjnldsv]

Design fixes

Please elaborate :)

Well, we updated and fixed design on the component repo, so we now beneficiate from those here 😁

[ChristophWurst]

🐘

[nickvergessen]

Should this default be added to our lib instead? feels strange, if all usages should add this 🤔

[skjnldsv]

@nickvergessen there is a default to 150px.
You can omit it if you want :)
But it can lead to undesirable design.

Making it automatic was a bit too difficult.

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

Status of 16654: failure

• DB=sqlite, ENABLE_REDIS=false, PHP=7.3

Show full log

There was 1 failure:
1) TrashbinTest::testExpireOldFiles
Failed asserting that null is identical to 'file2.txt'.
/drone/src/github.com/nextcloud/server/apps/files_trashbin/tests/TrashbinTest.php:186
--
There was 1 risky test:
1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

• DB=mysql, ENABLE_REDIS=false, PHP=7.3

Show full log

There was 1 failure:
1) TrashbinTest::testExpireOldFiles
Failed asserting that null is identical to 'file2.txt'.
/drone/src/github.com/nextcloud/server/apps/files_trashbin/tests/TrashbinTest.php:186
--
There was 1 risky test:
1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

• TESTS=acceptance, TESTS-ACCEPTANCE=app-comments
  • tests/acceptance/features/app-comments.feature:10

Show full log

 Scenario: open the comments for a different file # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-comments.feature:10
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
When I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
Then I see that there are no comments # CommentsAppContext::iSeeThatThereAreNoComments()

• TESTS=acceptance, TESTS-ACCEPTANCE=app-files
  • tests/acceptance/features/app-files.feature:133

Show full log

 Scenario: show deleted files for a second time # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:133
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I open the "Deleted files" section # AppNavigationContext::iOpenTheSection()
And I see that the current section is "Deleted files" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
And I open the "All files" section # AppNavigationContext::iOpenTheSection()
And I see that the current section is "All files" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
And I delete "welcome.txt" # FileListContext::iDelete()
When I open the "Deleted files" section # AppNavigationContext::iOpenTheSection()
Then I see that the current section is "Deleted files" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

• TESTS=acceptance, TESTS-ACCEPTANCE=app-files-tags
  • tests/acceptance/features/app-files-tags.feature:70

Show full log

 Scenario: remove tags using the dropdown in the details view # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-tags.feature:70
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage()
And I open the "Tag management" section # AppNavigationContext::iOpenTheSection()
And I see that the button to select tags is shown # SettingsContext::iSeeThatTheButtonToSelectTagsIsShown()
And I create the tag "tag1" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I create the tag "tag2" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I create the tag "tag3" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I create the tag "tag4" in the settings # SettingsContext::iCreateTheTagInTheSettings()
And I see that the dropdown for tags in the settings eventually contains the tag "tag1" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I see that the dropdown for tags in the settings eventually contains the tag "tag2" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I see that the dropdown for tags in the settings eventually contains the tag "tag3" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I see that the dropdown for tags in the settings eventually contains the tag "tag4" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
And I log out # SettingsMenuContext::iLogOut()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
And I open the input field for tags in the details view # FilesAppContext::iOpenTheInputFieldForTagsInTheDetailsView()
And I check the tag "tag2" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView()
And I check the tag "tag4" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView()
And I check the tag "tag3" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView()
When I uncheck the tag "tag2" in the dropdown for tags in the details view # FilesAppContext::iUncheckTheTagInTheDropdownForTagsInTheDetailsView()
And I uncheck the tag "tag4" in the dropdown for tags in the details view # FilesAppContext::iUncheckTheTagInTheDropdownForTagsInTheDetailsView()
Then I see that the tag "tag2" in the dropdown for tags in the details view is not checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsNotChecked()
And I see that the tag "tag4" in the dropdown for tags in the details view is not checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsNotChecked()
And I see that the tag "tag3" in the dropdown for tags in the details view is checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked()
And I see that the input field for tags in the details view does not contain the tag "tag2" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewDoesNotContainTheTag()
Failed asserting that false is true.
And I see that the input field for tags in the details view does not contain the tag "tag4" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewDoesNotContainTheTag()
And I see that the input field for tags in the details view contains the tag "tag3" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewContainsTheTag()

• TESTS=acceptance, TESTS-ACCEPTANCE=header
  • tests/acceptance/features/header.feature:30
  • tests/acceptance/features/header.feature:43

Show full log

 Scenario: just added users are seen in the contacts menu # /drone/src/github.com/nextcloud/server/tests/acceptance/features/header.feature:30
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
New user button in Users Settings could not be found (NoSuchElementException)
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I create user user1 with password 123456acb # UsersSettingsContext::iCreateUserWithPassword()
And I see that the list of users contains the user user1 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
When I open the Contacts menu # ContactsMenuContext::iOpenTheContactsMenu()
Then I see that the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
And I see that the contact "user0" in the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
And I see that the contact "user1" in the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
sh: 1: kill: No such process
Scenario: search for other users in the contacts menu # /drone/src/github.com/nextcloud/server/tests/acceptance/features/header.feature:43
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
New user button in Users Settings could not be found (NoSuchElementException)
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I create user user1 with password 123456acb # UsersSettingsContext::iCreateUserWithPassword()
And I see that the list of users contains the user user1 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the Contacts menu # ContactsMenuContext::iOpenTheContactsMenu()
And I see that the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
And I see that the contact "user0" in the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
And I see that the contact "user1" in the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
And I see that the Contacts menu search input is shown # ContactsMenuContext::iSeeThatTheContactsMenuSearchInputIsShown()
When I search for the user "user0" # ContactsMenuContext::iSearchForTheUser()
Then I see that the contact "user1" in the Contacts menu is eventually not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsEventuallyNotShown()
And I see that the contact "user0" in the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
sh: 1: kill: No such process

• TESTS=acceptance, TESTS-ACCEPTANCE=login
  • tests/acceptance/features/login.feature:38

Show full log

 Scenario: log in with invalid user once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:38
Given I act as John # ActorContext::iActAs()
And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
When I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I create user unknownUser with password 123456acb # UsersSettingsContext::iCreateUserWithPassword()
And I see that the list of users contains the user unknownUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I act as John # ActorContext::iActAs()
And I log in with user unknownUser and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()
Then I see that the current page is the Files app # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()
Failed asserting that 'http://acceptance-login/index.php/login?user=unknownUser' starts with "http://acceptance-login/index.php/apps/files/".

• TESTS=acceptance, TESTS-ACCEPTANCE=users
  • tests/acceptance/features/users.feature:13
  • tests/acceptance/features/users.feature:25
  • tests/acceptance/features/users.feature:35
  • tests/acceptance/features/users.feature:47

Show full log

 Scenario: create a new user with a custom display name # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:13
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
When I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I set the user name for the new user to "test" # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
And I set the password for the new user to "123456acb" # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
And I create the new user # UsersSettingsContext::iCreateTheNewUser()
Then I see that the list of users contains the user "test" # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I see that the display name for the user "test" is "Test display name" # UsersSettingsContext::iSeeThatTheDisplayNameForTheUserIs()
Row for user test in Users Settings could not be found after 100 seconds
displayName cell for user test in Users Settings could not be found after 100 seconds
displayName input for user test in Users Settings could not be found after 100 seconds (NoSuchElementException)
Scenario: delete a user # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:25
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Delete user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Delete user" action in the user0 actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the list of users does not contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
Scenario: disable a user # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:35
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Disable user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Disable user" action in the user0 actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the list of users does not contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
When I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
Then I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
Scenario: users navigation without disabled users # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:47
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
And I see that the list of users contains the user disabledUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user disabledUser # UsersSettingsContext::iOpenTheActionsMenuOf()
And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
Failed asserting that false is true.
When I click the "Enable user" action in the disabledUser actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()
When I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()

@danxuliu two more "no such process" errors on headers.features

[MorrisJobke]

• tests/acceptance/features/users.feature:13
• tests/acceptance/features/users.feature:25
• tests/acceptance/features/users.feature:35
• tests/acceptance/features/users.feature:47

It seems that those were there before this PR.