Skip to content

[stable15] Do not cut full color on accessibility svg color invert - #14516

Merged
MorrisJobke merged 1 commit into
stable15from
backport/14499/stable15
Mar 5, 2019
Merged

[stable15] Do not cut full color on accessibility svg color invert#14516
MorrisJobke merged 1 commit into
stable15from
backport/14499/stable15

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #14499

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobkeMorrisJobke added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 4, 2019
@faily-bot

faily-botBot commented Mar 4, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16722: failure

  • TESTS=acceptance, TESTS-ACCEPTANCE=app-files
    • tests/acceptance/features/app-files.feature:133
    • tests/acceptance/features/app-files.feature:172
Show full log
 Scenario: show deleted files for a second time # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:133
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I open the "Deleted files" section # AppNavigationContext::iOpenTheSection()
And I see that the current section is "Deleted files" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
And I open the "All files" section # AppNavigationContext::iOpenTheSection()
And I see that the current section is "All files" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
And I delete "welcome.txt" # FileListContext::iDelete()
When I open the "Deleted files" section # AppNavigationContext::iOpenTheSection()
Then I see that the current section is "Deleted files" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
Scenario: copy a file to another folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:172
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Destination" # FileListContext::iCreateANewFolderNamed()
When I start the move or copy operation for "welcome.txt" # FileListContext::iStartTheMoveOrCopyOperationFor()
And I select "Destination" in the file picker # FilePickerContext::iSelectInTheFilePicker()
Row for file Destination in the file picker dialog could not be found after 100 seconds (NoSuchElementException)
And I copy to the last selected folder in the file picker # FilePickerContext::iCopyToTheLastSelectedFolderInTheFilePicker()
Then I enter in the folder named "Destination" # FileListContext::iEnterInTheFolderNamed()
And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

@MorrisJobke
MorrisJobke merged commit 0f95b95 into stable15Mar 5, 2019
@ChristophWurst
ChristophWurst deleted the backport/14499/stable15 branch March 5, 2019 09:04
@rullzerrullzer mentioned this pull request Mar 29, 2019
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: accessibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@juliusknorr@skjnldsv