Skip to content

[stable15] dav: Fix handling of chunked WebDAV upload - #14517

Merged
MorrisJobke merged 1 commit into
stable15from
backport/13871/stable15
Mar 5, 2019
Merged

[stable15] dav: Fix handling of chunked WebDAV upload#14517
MorrisJobke merged 1 commit into
stable15from
backport/13871/stable15

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #13871

When $data is null (which can happen when $request->getBodyAsStream() returns
null), the Exceptions says "copied bytes: 0, expected filesize: 0", which
sounds more like success...
@faily-bot

faily-botBot commented Mar 4, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16724: failure

  • DB=mysqlmb4, ENABLE_REDIS=false, PHP=7.3
Show full log
There was 1 failure:
1) TrashbinTest::testExpireOldFiles
Failed asserting that null is identical to 'file2.txt'.
/drone/src/github.com/nextcloud/server/apps/files_trashbin/tests/TrashbinTest.php:186
--
There was 1 risky test:
1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions
  • TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link
    • tests/acceptance/features/app-files-sharing-link.feature:81
Show full log
 Scenario: owner sees folder created in the public page of an editable shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:81
Given I act as John # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Editable shared folder" # FileListContext::iCreateANewFolderNamed()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I share the link for "Editable shared folder" # FilesAppSharingContext::iShareTheLinkFor()
And I set the shared link as editable # FilesAppSharingContext::iSetTheSharedLinkAsEditable()
And I write down the shared link # FilesAppSharingContext::iWriteDownTheSharedLink()
Element is no longer attached to the DOM
For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
System info: host: 'ba1f1ef28e3d', ip: '172.17.0.11', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-43-generic', java.version: '1.8.0_91'
Driver info: driver.version: unknown (WebDriver\Exception\StaleElementReference)
And I act as Jane # ActorContext::iActAs()
And I visit the shared link I wrote down # PublicShareContext::iVisitTheSharedLinkIWroteDown()
And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
And I create a new folder named "Subfolder" # FileListContext::iCreateANewFolderNamed()
And I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
When I act as John # ActorContext::iActAs()
And I enter in the folder named "Editable shared folder" # FileListContext::iEnterInTheFolderNamed()
Then I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Mar 5, 2019

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@ariselsengariselseng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MorrisJobke
MorrisJobke merged commit 6e5a930 into stable15Mar 5, 2019
@MorrisJobke
MorrisJobke deleted the backport/13871/stable15 branch March 5, 2019 09:05
@rullzerrullzer mentioned this pull request Mar 29, 2019
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@ariselseng@jplitza