Revert "Disable fragile tests for now"

[MorrisJobke]

This reverts commit 40e04c8.

As promised in #14541

@ChristophWurst@skjnldsv@juliushaertl@danxuliu Any idea why they are failing?

[MorrisJobke]

Seems that all except the user ones are working: https://drone.nextcloud.com/nextcloud/server/30933/61/1 let me retrigger it 5 times to verify.

Statuses:

Status of 30933: failure

acceptance-app-comments ("fixed" with #21934)

• /drone/src/tests/acceptance/features/app-comments.feature:21
• /drone/src/tests/acceptance/features/app-comments.feature:126
• /drone/src/tests/acceptance/features/app-comments.feature:233
• /drone/src/tests/acceptance/features/app-comments.feature:288
• /drone/src/tests/acceptance/features/app-comments.feature:308

Show full log

 Scenario: write a comment in a file right after writing a comment in another file # /drone/src/tests/acceptance/features/app-comments.feature:21
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Comment in Folder" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Comment in Folder" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Comment in Folder" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
When I create a new comment with "Comment in welcome.txt" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
Then I see a comment with "Comment in welcome.txt" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that there is no comment with "Comment in Folder" as message # CommentsAppContext::iSeeThatThereIsNoCommentWithAsMessage()
Scenario: unread comment icon shown for comment written by the sharer in a shared folder # /drone/src/tests/acceptance/features/app-comments.feature:126
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as John # ActorContext::iActAs()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I share "Folder" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
When I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
Then I see that "Folder" has unread comments # FileListContext::iSeeThatHasUnreadComments()
And I open the unread comments for "Folder" # FileListContext::iOpenTheUnreadCommentsFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Scenario: search a comment in a child folder # /drone/src/tests/acceptance/features/app-comments.feature:233
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Child folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Child folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
Then I see that the search result 1 is "user0Hello world" # SearchContext::iSeeThatTheSearchResultIs()
And I see that the search result 1 was found in "Folder/Child folder" # SearchContext::iSeeThatTheSearchResultWasFoundIn()
Scenario: open a search result for a comment in a folder named like its child folder # /drone/src/tests/acceptance/features/app-comments.feature:288
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
And I open the search result 1 # SearchContext::iOpenTheSearchResult()
Then I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "Folder" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that the file list is currently in "Home" # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I see that the file list contains a file named "Folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Scenario: open a search result for a comment in a child folder # /drone/src/tests/acceptance/features/app-comments.feature:308
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Child folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Child folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
And I open the search result 1 # SearchContext::iOpenTheSearchResult()
Then I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "Child folder" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that the file list is currently in "Home/Folder" # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
And I see that the file list contains a file named "Child folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

acceptance-users

• /drone/src/tests/acceptance/features/users.feature:13

Show full log

 Scenario: create a new user with a custom display name # /drone/src/tests/acceptance/features/users.feature:13
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
When I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I set the user name for the new user to "test" # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
And I set the password for the new user to "123456acb" # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
And I create the new user # UsersSettingsContext::iCreateTheNewUser()
Then I see that the list of users contains the user "test" # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I see that the display name for the user "test" is "Test display name" # UsersSettingsContext::iSeeThatTheDisplayNameForTheUserIs()
displayName input for user test in Users Settings could not be found after 100 seconds (NoSuchElementException)

Status of 30935: failure

acceptance-app-comments ("fixed" with #21934)

• /drone/src/tests/acceptance/features/app-comments.feature:21
• /drone/src/tests/acceptance/features/app-comments.feature:126
• /drone/src/tests/acceptance/features/app-comments.feature:233
• /drone/src/tests/acceptance/features/app-comments.feature:288
• /drone/src/tests/acceptance/features/app-comments.feature:308

Show full log

 Scenario: write a comment in a file right after writing a comment in another file # /drone/src/tests/acceptance/features/app-comments.feature:21
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Comment in Folder" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Comment in Folder" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Comment in Folder" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
When I create a new comment with "Comment in welcome.txt" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
Then I see a comment with "Comment in welcome.txt" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that there is no comment with "Comment in Folder" as message # CommentsAppContext::iSeeThatThereIsNoCommentWithAsMessage()
Scenario: unread comment icon shown for comment written by the sharer in a shared folder # /drone/src/tests/acceptance/features/app-comments.feature:126
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as John # ActorContext::iActAs()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I share "Folder" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
When I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
Then I see that "Folder" has unread comments # FileListContext::iSeeThatHasUnreadComments()
And I open the unread comments for "Folder" # FileListContext::iOpenTheUnreadCommentsFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Scenario: search a comment in a child folder # /drone/src/tests/acceptance/features/app-comments.feature:233
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Child folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Child folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
Then I see that the search result 1 is "user0Hello world" # SearchContext::iSeeThatTheSearchResultIs()
And I see that the search result 1 was found in "Folder/Child folder" # SearchContext::iSeeThatTheSearchResultWasFoundIn()
Scenario: open a search result for a comment in a folder named like its child folder # /drone/src/tests/acceptance/features/app-comments.feature:288
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
And I open the search result 1 # SearchContext::iOpenTheSearchResult()
Then I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "Folder" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that the file list is currently in "Home" # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I see that the file list contains a file named "Folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Scenario: open a search result for a comment in a child folder # /drone/src/tests/acceptance/features/app-comments.feature:308
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Child folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Child folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
And I open the search result 1 # SearchContext::iOpenTheSearchResult()
Then I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "Child folder" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that the file list is currently in "Home/Folder" # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
And I see that the file list contains a file named "Child folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

acceptance-app-files-sharing

• /drone/src/tests/acceptance/features/app-files-sharing.feature:338

Show full log

 Scenario: sharee can revoke create permission from reshare after the sharer disabled it # /drone/src/tests/acceptance/features/app-files-sharing.feature:338
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as Jim # ActorContext::iActAs()
And I am logged in as "user1" # LoginPageContext::iAmLoggedInAs()
And I act as John # ActorContext::iActAs()
And I create a new folder named "Shared folder" # FileListContext::iCreateANewFolderNamed()
And I see that the file list contains a file named "Shared folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I share "Shared folder" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I share "Shared folder" with "user1" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user1" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as John # ActorContext::iActAs()
And I set the share with "user0" as not creatable # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
And I see that "user0" can not create in the share # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
And I act as Jim # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I enter in the folder named "Shared folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Subfolder" # FileListContext::iCreateANewFolderNamed()
And I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
When I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I open the details view for "Shared folder" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I open the "Sharing" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
And I set the share with "user1" as not creatable # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
Then I see that "user1" can not create in the share # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
And I see that "user1" can not be allowed to create in the share # FilesAppSharingContext::iSeeThatCanNotBeAllowedToCreateInTheShare()
And I act as Jim # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I enter in the folder named "Shared folder" # FileListContext::iEnterInTheFolderNamed()
And I see that it is not possible to create new files # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
Failed asserting that true is false.

acceptance-users

• /drone/src/tests/acceptance/features/users.feature:13

Show full log

 Scenario: create a new user with a custom display name # /drone/src/tests/acceptance/features/users.feature:13
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
When I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I set the user name for the new user to "test" # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
And I set the password for the new user to "123456acb" # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
And I create the new user # UsersSettingsContext::iCreateTheNewUser()
Then I see that the list of users contains the user "test" # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I see that the display name for the user "test" is "Test display name" # UsersSettingsContext::iSeeThatTheDisplayNameForTheUserIs()
displayName input for user test in Users Settings could not be found after 100 seconds (NoSuchElementException)

The ones below have the fix for the user acceptance test included

Status of 30941: failure

mysql5.6-php7.2

Show full log

There was 1 failure:
1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #141 ('folder', 9, 13)
Failed asserting that false is true.
/drone/src/apps/files_sharing/tests/SharedMountTest.php:367
--
There was 1 risky test:
1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions
/drone/src/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php:115

acceptance-app-comments ("fixed" with #21934)

• /drone/src/tests/acceptance/features/app-comments.feature:21
• /drone/src/tests/acceptance/features/app-comments.feature:126
• /drone/src/tests/acceptance/features/app-comments.feature:233
• /drone/src/tests/acceptance/features/app-comments.feature:288
• /drone/src/tests/acceptance/features/app-comments.feature:308

Show full log

 Scenario: write a comment in a file right after writing a comment in another file # /drone/src/tests/acceptance/features/app-comments.feature:21
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Comment in Folder" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Comment in Folder" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Comment in Folder" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
When I create a new comment with "Comment in welcome.txt" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
Then I see a comment with "Comment in welcome.txt" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that there is no comment with "Comment in Folder" as message # CommentsAppContext::iSeeThatThereIsNoCommentWithAsMessage()
Scenario: unread comment icon shown for comment written by the sharer in a shared folder # /drone/src/tests/acceptance/features/app-comments.feature:126
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as John # ActorContext::iActAs()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I share "Folder" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
When I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
Then I see that "Folder" has unread comments # FileListContext::iSeeThatHasUnreadComments()
And I open the unread comments for "Folder" # FileListContext::iOpenTheUnreadCommentsFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Scenario: search a comment in a child folder # /drone/src/tests/acceptance/features/app-comments.feature:233
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Child folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Child folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
Then I see that the search result 1 is "user0Hello world" # SearchContext::iSeeThatTheSearchResultIs()
And I see that the search result 1 was found in "Folder/Child folder" # SearchContext::iSeeThatTheSearchResultWasFoundIn()
Scenario: open a search result for a comment in a folder named like its child folder # /drone/src/tests/acceptance/features/app-comments.feature:288
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
And I open the search result 1 # SearchContext::iOpenTheSearchResult()
Then I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "Folder" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that the file list is currently in "Home" # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I see that the file list contains a file named "Folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Scenario: open a search result for a comment in a child folder # /drone/src/tests/acceptance/features/app-comments.feature:308
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Child folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Child folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
And I open the search result 1 # SearchContext::iOpenTheSearchResult()
Then I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "Child folder" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that the file list is currently in "Home/Folder" # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
And I see that the file list contains a file named "Child folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

acceptance-login

• /drone/src/tests/acceptance/features/login.feature:38

Show full log

 Scenario: log in with invalid user once fixed by admin # /drone/src/tests/acceptance/features/login.feature:38
Given I act as John # ActorContext::iActAs()
And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
When I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
New user button in Users Settings could not be found (NoSuchElementException)
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I create user unknownUser with password 123456acb # UsersSettingsContext::iCreateUserWithPassword()
And I see that the list of users contains the user unknownUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I act as John # ActorContext::iActAs()
And I log in with user unknownUser and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()
Then I see that the current page is the Files app # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()

acceptance-users

• /drone/src/tests/acceptance/features/users.feature:13

Show full log

 Scenario: create a new user with a custom display name # /drone/src/tests/acceptance/features/users.feature:13
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
When I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I set the user name for the new user to "test" # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
And I set the password for the new user to "123456acb" # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
And I create the new user # UsersSettingsContext::iCreateTheNewUser()
Then I see that the list of users contains the user "test" # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I see that the display name for the user "test" is "Test display name" # UsersSettingsContext::iSeeThatTheDisplayNameForTheUserIs()
Failed asserting that null matches expected 'Test display name'.

[MorrisJobke]

@danxuliu It seems that this was the problem for the failing user list tests. If I got this right the inputForUserInCell wraps the displayName class selector into an input type selector.

But this isn't the case anymore (most likely due to the Vue version of the users management):

Does that make sense?

[MorrisJobke]

Doesn't seem to work 🙈

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 30944: failure

acceptance-app-comments

• /drone/src/tests/acceptance/features/app-comments.feature:21
• /drone/src/tests/acceptance/features/app-comments.feature:126
• /drone/src/tests/acceptance/features/app-comments.feature:233
• /drone/src/tests/acceptance/features/app-comments.feature:288
• /drone/src/tests/acceptance/features/app-comments.feature:308

Show full log

 Scenario: write a comment in a file right after writing a comment in another file # /drone/src/tests/acceptance/features/app-comments.feature:21
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Comment in Folder" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Comment in Folder" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Comment in Folder" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
When I create a new comment with "Comment in welcome.txt" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
Then I see a comment with "Comment in welcome.txt" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that there is no comment with "Comment in Folder" as message # CommentsAppContext::iSeeThatThereIsNoCommentWithAsMessage()
Scenario: unread comment icon shown for comment written by the sharer in a shared folder # /drone/src/tests/acceptance/features/app-comments.feature:126
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as John # ActorContext::iActAs()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I share "Folder" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
When I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
Then I see that "Folder" has unread comments # FileListContext::iSeeThatHasUnreadComments()
And I open the unread comments for "Folder" # FileListContext::iOpenTheUnreadCommentsFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Scenario: search a comment in a child folder # /drone/src/tests/acceptance/features/app-comments.feature:233
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Child folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Child folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
Then I see that the search result 1 is "user0Hello world" # SearchContext::iSeeThatTheSearchResultIs()
And I see that the search result 1 was found in "Folder/Child folder" # SearchContext::iSeeThatTheSearchResultWasFoundIn()
Scenario: open a search result for a comment in a folder named like its child folder # /drone/src/tests/acceptance/features/app-comments.feature:288
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
And I open the search result 1 # SearchContext::iOpenTheSearchResult()
Then I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "Folder" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that the file list is currently in "Home" # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I see that the file list contains a file named "Folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Scenario: open a search result for a comment in a child folder # /drone/src/tests/acceptance/features/app-comments.feature:308
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Child folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Child folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
And I open the search result 1 # SearchContext::iOpenTheSearchResult()
Then I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "Child folder" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that the file list is currently in "Home/Folder" # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
And I see that the file list contains a file named "Child folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

acceptance-users

• /drone/src/tests/acceptance/features/users.feature:13

Show full log

 Scenario: create a new user with a custom display name # /drone/src/tests/acceptance/features/users.feature:13
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
When I click the New user button # UsersSettingsContext::iClickTheNewUserButton()
And I see that the new user form is shown # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
And I set the user name for the new user to "test" # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
And I set the password for the new user to "123456acb" # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
And I create the new user # UsersSettingsContext::iCreateTheNewUser()
Then I see that the list of users contains the user "test" # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I see that the display name for the user "test" is "Test display name" # UsersSettingsContext::iSeeThatTheDisplayNameForTheUserIs()
Failed asserting that null matches expected 'Test display name'.

[MorrisJobke]

Seems that all except the users.feature:13 works fine. So let's get them in again via #21940 and then focus on the remaining one in this ticket here.