Skip to content

Pin the jquery version to 2.1.4 - #14563

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/jquery-version
Mar 6, 2019
Merged

Pin the jquery version to 2.1.4#14563
MorrisJobke merged 1 commit into
masterfrom
fix/jquery-version

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Mar 6, 2019

Copy link
Copy Markdown
Member

v2.2.x behaves different in terms of when the page is ready. See #13496 (comment) for more detail. Apparently 7207a77 updated jquery accidentally.

Fixes#14556

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

How to test: run npm ls jquery on master and this branch ;)

@ChristophWurstChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 6, 2019
@faily-bot

faily-botBot commented Mar 6, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16815: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:75
Show full log
 Scenario: View app details for app store apps # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:75
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the Apps management # SettingsMenuContext::iOpenTheAppsManagement()
And I open the "Tools" section # AppNavigationContext::iOpenTheSection()
Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)
When I click on the "Antivirus for files" app # AppsManagementContext::iClickOnTheApp()
Then I see that the app details are shown # AppsManagementContext::iSeeThatTheAppDetailsAreShown()

@MorrisJobke
MorrisJobke merged commit 540ec4f into masterMar 6, 2019
@MorrisJobke
MorrisJobke deleted the fix/jquery-version branch March 6, 2019 14:32
@MorrisJobkeMorrisJobke mentioned this pull request Mar 6, 2019
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugregression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst@rullzer@juliusknorr@skjnldsv@MorrisJobke